Git Product home page Git Product logo

Comments (13)

wefixit-AT avatar wefixit-AT commented on August 24, 2024

I’m closing this issue because it has been inactive for a few months. This probably means that it is not reproducible or it has been fixed in a newer version.

from ovirtbackup.

stolp avatar stolp commented on August 24, 2024

I think this issue should not be closed blindly.

AFAICS the code part in question has not been changed and the issue raised seems reasonable to me.

from ovirtbackup.

wefixit-AT avatar wefixit-AT commented on August 24, 2024

Thanks for the quick response, I reopen the issue.
Have you tested the issue with the latest release? And please tell us more about your environment.

from ovirtbackup.

stolp avatar stolp commented on August 24, 2024

I am first going to test the api4 changes against our oVirt 4.3 installation anyway.

So I can include this corner case as well.

I will let you know of the results here.

Thanks for still caring for this project!

from ovirtbackup.

MEy3 avatar MEy3 commented on August 24, 2024

i've tested my changes from my initial post now for almost one year and it fixed the behavior and working without any issues on oVirt 4.3.

Also from me, thank you all for still working on this project.
oVirtBackup is essential for me to make timed backups from ~50 systems on a daily basis and it would be really nice to see it working with oVirt 4.4 API.

from ovirtbackup.

wefixit-AT avatar wefixit-AT commented on August 24, 2024

@MEy3 Thanks for the response

@stolp If you still have problems please open a new issue

from ovirtbackup.

MEy3 avatar MEy3 commented on August 24, 2024

So you added my changes to your code? The Issue is in your lastest public version of this project still present until you changed your code like i did and written in the initial post of this issue.

from ovirtbackup.

stolp avatar stolp commented on August 24, 2024

@MEy3 I created a pull request with your changes. Please review.

Sadly I was not able to test this, as I wasn't able to run current master against our oVirt 4.3 installation.

from ovirtbackup.

wefixit-AT avatar wefixit-AT commented on August 24, 2024

I created a new branch to test against my oVirt 4.3 environment. There I changed the line. I'm not sure if double "_" solves the problem. Please test the branch with your version.

from ovirtbackup.

stolp avatar stolp commented on August 24, 2024

I will test this, thanks!

from ovirtbackup.

MEy3 avatar MEy3 commented on August 24, 2024

The ““ is the separator between VMname and Date. Without “” the script fails to get the proper name of the Test1 vm clone and deletes the last one that can be found from Test2 which is wrong. Also it happend that not only the wrong clone get’s deleted also so entire VM Test2 incl. Discimage image. That happens twice so I had to restore it from an older backup and modified the script last year. “__*” takes care to get the exact name of the vm and ensure due to the separator to only delete the correct clone.

from ovirtbackup.

wefixit-AT avatar wefixit-AT commented on August 24, 2024

It is not possible with any release that the whole VM is delete only if you have nothing set to "vm_middle" in your config. But if you wish I add this to the master and oVirt4.3 branch

from ovirtbackup.

wefixit-AT avatar wefixit-AT commented on August 24, 2024

If you still unsatisfied, leave a comment.

from ovirtbackup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.