Node Module Error (newline-json\parser.js) about webtorrent-hybrid HOT 11 CLOSED

Same error here.

Aparrently, is problem of new-linejson

mappum/electron-eval#50

@mappum @feross

from webtorrent-hybrid.

It appears both occurrences have happened on Windows. Also, newline-json gives that error if the data begins with \n, so we just have to find where that newline is coming from.

from webtorrent-hybrid.

parse.js
commenting out lines 30 and 31 are a band-aid let me know if helps you

from webtorrent-hybrid.

I already try commenting out line. But don't still work here.

from webtorrent-hybrid.

That newline-json stream is receiving the stdout output of the Electron child process. So I think we will just have to ensure we consume the first byte (\n) of the stdout stream when using Windows (although it sucks that we have to).

from webtorrent-hybrid.

why is windows the problem?

from webtorrent-hybrid.

Can you guys test with electron-eval on this branch: https://github.com/mappum/electron-eval/tree/newline-fix?

from webtorrent-hybrid.

Nothing here.

I made all changes.

https://github.com/mappum/electron-eval/compare/newline-fix

And still show error here.

from webtorrent-hybrid.

I try with this:

   this.child.stdout.once('data', (data) => {
      // this hack fixes issues where some environments (namely Windows)
      // prepend a '\n' at the beginning of the stdout stream. This breaks
      // the JSON parser, so if the stream starts with '\n' we skip it
      while(true){
            var dec = data.toString().charCodeAt(0) ;

            if(dec != 13 && dec != 10) break;
            data = data.slice(1, data.length)
      }

      this.stdout.write(data)
      this.child.stdout.pipe(this.stdout)

    })

This aparently work here. Optimize my code, please.

Basicaly you need a left trim function in data array ..

Sorry my english. Thank you

from webtorrent-hybrid.

This should be fixed as of [email protected]. Can you guys reinstall and confirm that the issue is fixed?

from webtorrent-hybrid.

Just tested on Windows. This looks fixed to me. Thanks @mappum.

from webtorrent-hybrid.