Git Product home page Git Product logo

Comments (11)

websemantics avatar websemantics commented on June 10, 2024 1

I will look forward to your PR @rugdealer, this is exciting 👍
@jehartzog hi, do you want to wait until we have @rugdealer PR? it sounds fully featured,

from vimeo-upload.

jehartzog avatar jehartzog commented on June 10, 2024 1

I'll definitely wait, but just letting you know I'll be testing and possibly pushing to production when ready, so can help out whenever needed.

from vimeo-upload.

websemantics avatar websemantics commented on June 10, 2024 1

@rugdealer, I don't mind having own fork vimeo-chunk-upload and I'll surely link it from README.md for the benefit of interested developers,

I've created a new branchchunk-upload in case you'd like to integrate with the current codebase (fork, update, PR). Like you mentioned, adding docs and updating demo code for other developers to fully take advantage of this new feature is preferred,

If you do go with the later, make sure you add yourself to the authors list (i.e. package.json etc) as this is a major contribution and since your help will also be needed to fix any bugs :)

from vimeo-upload.

rottenoats avatar rottenoats commented on June 10, 2024 1

@websemantics ok great. I've forked the project and started adding the changes. I'll send the pull request in a few days to your chunk-upload branch.

from vimeo-upload.

websemantics avatar websemantics commented on June 10, 2024

I believe chunks upload is to enable pause / resume and not sure if that would solve uploading large files. Don't have plans for implementing this atm, put would welcome any contributions,

from vimeo-upload.

rottenoats avatar rottenoats commented on June 10, 2024

Hey, thanks for the response. I'll look into it and if I find a solution I'll contribute.
Also wanted to know if there is a way to have it upload in chunks by default to be able to test to see if the error still shows up?

from vimeo-upload.

rottenoats avatar rottenoats commented on June 10, 2024

@websemantics I forgot to get back to you, but I created a typescript project based off of your vimeo-upload. It uploads purely by chunks (and updates the chunk size based on the connection speed). If you're interested in using it, I could eventually submit a pull request. It could be seen a v2 of your original project. However, I'd have to change a few things to make it more dynamic.

from vimeo-upload.

websemantics avatar websemantics commented on June 10, 2024

Hi @rugdealer,
That would be a great contribution initially as a usage example then as an integral part of the plugin. Does this have a progress indicator? as a callback function maybe?
All the best,

from vimeo-upload.

rottenoats avatar rottenoats commented on June 10, 2024

@websemantics
Yes, it actually has two progress indicators. One for the chunk upload and one for the total upload. You can check out a version I pushed two months ago https://github.com/rugdealer/vimeo-upload . I changed a few things for the company I work for.

I'll prepare an easier version to use. I'll keep you posted.

In the index.html, it's pretty much the same thing you do.

function handleFileSelect(evt){
            evt.stopPropagation();
            evt.preventDefault();
            var files = evt.dataTransfer ? evt.dataTransfer.files : $(this).get(0).files
            vs.bindChunkProgressBar(document.getElementById('progress_partial'));
            vs.bindProgressBar(document.getElementById('progress'));
            vs.bindEstimatedTimeElem(document.getElementById('results'));
            vs.start({
                file: files[0]
            });
        }

Edit

Yeah, i'll add some interfaces and make it all round cleaner. I'm using a cleaner version for the company. It works well. Tested it with a 20g file without getting any errors.

from vimeo-upload.

jehartzog avatar jehartzog commented on June 10, 2024

I am also using a slightly modified version of vimeo-upload in production and am very interested in the ability to upload via chunks. Right now not all my client's large file uploads go through, most often on the clients with poorer internet connections.

I'd be happy to put together a PR, let me know.

from vimeo-upload.

rottenoats avatar rottenoats commented on June 10, 2024

I've modified quite a bit with the project. I'm currently debugging and I expect the first version of the project to be finished in a few days. How should we handle the PR? Should a branch be created? The tricky part is, it's a project started from scratch so it uses a completely different .git. Should the project be completely separate and renamed "vimeo-chunk-upload" ? Please let me know what you think would be best @websemantics thanks.

EDIT: I also need to finish documentation and code commenting.

from vimeo-upload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.