Comments (11)
I will look forward to your PR @rugdealer, this is exciting 👍
@jehartzog hi, do you want to wait until we have @rugdealer PR? it sounds fully featured,
from vimeo-upload.
I'll definitely wait, but just letting you know I'll be testing and possibly pushing to production when ready, so can help out whenever needed.
from vimeo-upload.
@rugdealer, I don't mind having own fork vimeo-chunk-upload
and I'll surely link it from README.md for the benefit of interested developers,
I've created a new branchchunk-upload
in case you'd like to integrate with the current codebase (fork, update, PR). Like you mentioned, adding docs and updating demo code for other developers to fully take advantage of this new feature is preferred,
If you do go with the later, make sure you add yourself to the authors list (i.e. package.json etc) as this is a major contribution and since your help will also be needed to fix any bugs :)
from vimeo-upload.
@websemantics ok great. I've forked the project and started adding the changes. I'll send the pull request in a few days to your chunk-upload
branch.
from vimeo-upload.
I believe chunks upload is to enable pause / resume and not sure if that would solve uploading large files. Don't have plans for implementing this atm, put would welcome any contributions,
from vimeo-upload.
Hey, thanks for the response. I'll look into it and if I find a solution I'll contribute.
Also wanted to know if there is a way to have it upload in chunks by default to be able to test to see if the error still shows up?
from vimeo-upload.
@websemantics I forgot to get back to you, but I created a typescript project based off of your vimeo-upload. It uploads purely by chunks (and updates the chunk size based on the connection speed). If you're interested in using it, I could eventually submit a pull request. It could be seen a v2 of your original project. However, I'd have to change a few things to make it more dynamic.
from vimeo-upload.
Hi @rugdealer,
That would be a great contribution initially as a usage example then as an integral part of the plugin. Does this have a progress indicator? as a callback function maybe?
All the best,
from vimeo-upload.
@websemantics
Yes, it actually has two progress indicators. One for the chunk upload and one for the total upload. You can check out a version I pushed two months ago https://github.com/rugdealer/vimeo-upload . I changed a few things for the company I work for.
I'll prepare an easier version to use. I'll keep you posted.
In the index.html, it's pretty much the same thing you do.
function handleFileSelect(evt){
evt.stopPropagation();
evt.preventDefault();
var files = evt.dataTransfer ? evt.dataTransfer.files : $(this).get(0).files
vs.bindChunkProgressBar(document.getElementById('progress_partial'));
vs.bindProgressBar(document.getElementById('progress'));
vs.bindEstimatedTimeElem(document.getElementById('results'));
vs.start({
file: files[0]
});
}
Edit
Yeah, i'll add some interfaces and make it all round cleaner. I'm using a cleaner version for the company. It works well. Tested it with a 20g file without getting any errors.
from vimeo-upload.
I am also using a slightly modified version of vimeo-upload in production and am very interested in the ability to upload via chunks. Right now not all my client's large file uploads go through, most often on the clients with poorer internet connections.
I'd be happy to put together a PR, let me know.
from vimeo-upload.
I've modified quite a bit with the project. I'm currently debugging and I expect the first version of the project to be finished in a few days. How should we handle the PR? Should a branch be created? The tricky part is, it's a project started from scratch so it uses a completely different .git. Should the project be completely separate and renamed "vimeo-chunk-upload" ? Please let me know what you think would be best @websemantics thanks.
EDIT: I also need to finish documentation and code commenting.
from vimeo-upload.
Related Issues (20)
- handleFileSelect Does not automatically called
- 403 error HOT 2
- onContentUploadError_ handler for Request header field X-Upload-Content-Type is not allowed by Access-Control-Allow-Headers in preflight response.
- XMLHttpRequest is not defined HOT 1
- privacy setting HOT 3
- Pull not Post
- Error: Not Found HOT 2
- Cordova: Upload with file url
- Metadata issue: Although the upload succeeds, the onComplete handler is never called
- changing default configuration HOT 1
- How to set privacy to Only people with the private link HOT 1
- Progresse bar 0 on Edge
- Error: Something strange occurred. Please try again. HOT 5
- Upload tags HOT 1
- Slow Vimeo upload speed using library compared to direct upload
- Name and description not set on upload
- Error: Unable to upload video. Please get in touch with the app's creator.
- Upload video on vimeo album folder? HOT 1
- Resume support
- TUS is required HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vimeo-upload.