Git Product home page Git Product logo

Comments (6)

ikreymer avatar ikreymer commented on July 4, 2024 1

This should now be fixed in 1.7.14

from replayweb.page.

ikreymer avatar ikreymer commented on July 4, 2024

Unfortunately, I think this is due to a bug in Chromium-based browserse where about:blank iframes created from a page that is controlled by a service worker is not immediately controlled, and therefore requests on it 'leak' to the upstream server.
You can see this by running a local version of replayweb.page with just say http-server -p 9990 and see that certain ad related requests 'leak' to the server when loaded in Chrome, but not in FF. The image you mention is one of those URLs, resulting in a 404.

I think the issue is likely: https://bugs.chromium.org/p/chromium/issues/detail?id=880768
While wombat tries to address this by having iframes load from a custom about:blank and srcdoc pages served by the service worker, I think there's still a race condition where the ad frames create an about:blank page, then immediately write to it with document.write() or load some resources like (new Image().src synchronously) which starts to load before the SW can take control of the page..
Firefox did a better job of fixing this issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1350850

In the case of the ReplayWeb.page app, it can actually catch these URLs and still handled them, so the ad does actually load from this page. Hopefully that issue will be fixed in Chrome at some point...

from replayweb.page.

treid003 avatar treid003 commented on July 4, 2024

Ok, thanks.

from replayweb.page.

ikreymer avatar ikreymer commented on July 4, 2024

Good News! Since original comment, there seems to actaully be a fix for this (see the linked commit). We can override document.write with a URL loaded from service worker that loads a blob, which generally fixes the issue!

from replayweb.page.

treid003 avatar treid003 commented on July 4, 2024

When I recently used the local version of ReplayWeb.page, it did not successfully replay the ad. It seems like some requests are still leaking to the upstream server.

Video: https://youtu.be/ow2VT0Bc5nk

2023-03-07_leaked_request

from replayweb.page.

treid003 avatar treid003 commented on July 4, 2024

Yes, it is working now. Thank you.

from replayweb.page.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.