Git Product home page Git Product logo

Comments (6)

ikreymer avatar ikreymer commented on May 31, 2024 1

One thing to try is to update the autofetch script to cause an additional wait as soon as any autofetching is started, similar to videos.. Need to test if that would be sufficient..
I dont know if networkidle0 is always the best option, I think I've seen some pages work better with waiting for load event..

from browsertrix-crawler.

ikreymer avatar ikreymer commented on May 31, 2024 1

It turns out its possible to wait for both networkidle0 and load events simply by passing an array to waitUntil.
The command-line option defaults to load,networkidle0 and I think that should do it for this use case.
Tested with the example linked and the srcsets seem to be getting captured.

from browsertrix-crawler.

ikreymer avatar ikreymer commented on May 31, 2024

Thanks for testing this in the browser! That does seem very strange, perhaps there is a timing issue and it moves to next page too quickly before they can be fetched.. There is not anything waiting to ensure the autofetcher is fully finished..

Could you try running with --waitUntil networkidle0 to see if that makes a difference? If not, maybe need to have additional waiting options.

from browsertrix-crawler.

rgaudin avatar rgaudin commented on May 31, 2024

Ah, that's it! Worked with networkidle0.

from browsertrix-crawler.

kelson42 avatar kelson42 commented on May 31, 2024

What should be done here? Should this working configuration be the default one?

from browsertrix-crawler.

kelson42 avatar kelson42 commented on May 31, 2024

@ikreymer Thank you. Would that be possible to make it available soon in a release?

from browsertrix-crawler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.