Should add `pop` public method for `ConcactSource` ? about webpack-sources HOT 7 CLOSED

/cc @sokra

from webpack-sources.

ConcatSource optimizes children internally after adding items. So removing might sometimes won't work as expected.

Anyway Sources are intended to be immutable after initial generation. remove doesn't fit good into the design.

Avoid adding items at first place. You can use an array to construct the items and add them to the ConcatSource after done.

from webpack-sources.

What do you mean, please clarify

from webpack-sources.

@evilebottnawi because I see ConcactSource have children is an array, when I want to remove an item from list but a must-do manual. If we support add method I think we support remove method too.

from webpack-sources.

@lamhieu-vk can you provide example of code, thanks

from webpack-sources.

@evilebottnawi for example, in plugin A do something and set assets is a ConcactSource have children like

const asset = ConcactSource {
  children: [
    'code1 - is a header comment', 
    'code2', 
    'code3 - is a source map',
  ],
}

in my plugin, I want to have a way to remove children in ConcactSource from plugin A return, for example:

 // remove comment header
asset.remove(0);

// or remove source map
asset.remove(2);

from webpack-sources.

@sokra can you tell me anything?

from webpack-sources.