Git Product home page Git Product logo

Comments (6)

KimmoTukiainen avatar KimmoTukiainen commented on July 20, 2024 1

Hey sorry for the slow response. There was nothing about worker-loader in webpack.config.js initially. We decided to take another route by not loading the file as inline, but by identifying those worker files with the suffix .worker.js

This configuration in webpack module rules solved the issue for me:

{ test: /\.worker\.js$/, use: [ { loader: "worker-loader", options: { name: "/[name].js" } } ] },

We of course had to exclude those files from the regular babel processing with this
test: /^(?!.*worker).+\.js$/,

from worker-loader.

michael-ciniawsky avatar michael-ciniawsky commented on July 20, 2024

Please provide your webpack.config.js aswell

from worker-loader.

jnields avatar jnields commented on July 20, 2024

Have you tried adding a trailing slash to your publicPath in the webpack config?

from worker-loader.

mbrowne avatar mbrowne commented on July 20, 2024

If anyone else encounters this, note that you can specify the public path using the inline syntax:

import GraphqlWorker from 'worker-loader?publicPath=/!worker.js';

I prefer the worker-loader! syntax because it makes it clearer that it's a special kind of import.

It would be nice if it were possible to specify default settings for a loader in webpack.config.js (for the publicPath setting in this case) so that the inline syntax would still work without having to specify publicPath on every import. But I don't know if webpack has such a feature.


Note: In the above example, I'm setting the publicPath to the root - /, since that's what I needed in my app - I just needed it to work for routes in subfolders. If your whole app is in a subfolder then you would do something like this:

import GraphqlWorker from 'worker-loader?publicPath=/my-subdir/!worker.js';

from worker-loader.

0x53A avatar 0x53A commented on July 20, 2024

I just also hit this issue. The workaround/fix is easy, but do you think it would be possible to fix this inside worker-loader?

Everything else in webpack seems to work ok without publicPath being slash-terminated, and it seems like an easy issue to solve.

from worker-loader.

Pyrolistical avatar Pyrolistical commented on July 20, 2024

yeah also ran into this. why does this loader assume publicPath has a trailing slash

from worker-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.