Comments (17)
Mhmm I'm not quite sure ... could be an issue with sass-graph. Could you remove the calls of markDependencies()
in your local installation of the sass-loader and check, if the problem still exists?
from sass-loader.
That does solve the error. What do you recommend next?
from sass-loader.
@jhnns I'm debugging your latest with the latest from sass-graph (1.0.1). Any reason you're locked in at an older version of sass-graph?
from sass-loader.
@jhnns I've tracked down the problem to sass-graph using for(var a in someArray) syntax and one of my dependencies must have added a method to array. Thus, crash, just as explained here: http://stackoverflow.com/a/3010848/1009332
https://github.com/xzyfer/sass-graph/blob/master/sass-graph.js#L54
for (var i in imports) {
[this.dir, cwd].forEach(function (path) {
if (path && this.loadPaths.indexOf(path) === -1) {
this.loadPaths.push(path);
}
}.bind(this));
var resolved = resolveSassPath(imports[i], _.uniq(this.loadPaths));
if (!resolved) return false;
// recurse into dependencies if not already enumerated
if(!_.contains(entry.imports, resolved)) {
entry.imports.push(resolved);
this.addFile(fs.realpathSync(resolved), filepath);
}
}
from sass-loader.
@justin808,
We submitted a pull request to sass-graph to fix some of the issues with sass-loader.
Since npm release was not made at that time, we tagged it to git commit.
Now @xzyfer is maintaining sass-graph and an npm release was made recently.
We should test it with sass-loader and migrate to latest version of sass-graph.
from sass-loader.
@akiran is there a fork/branch I should pull? I'm going to check that just changing the array iteration fixes my issue.
from sass-loader.
Now sass-graph is maintained at
https://github.com/xzyfer/sass-graph
from sass-loader.
Hey all, feel free to open issues and PR in sass-graph. I'm actively maintaining it.
There's a lot a clean up work to be done, which is coming.
from sass-loader.
This was blocking me:
Any ETA on when we might be able to see this fix and an update to sass-loader? I'd rather use the official versions than my own fork. Thanks! And if you're interested, please check out my sample project on using rails with webpack and react: https://github.com/justin808/react-webpack-rails-tutorial/tree/update-to-latest.
from sass-loader.
I've had a preliminary look at xzyfer/sass-graph#7. I have some feels about it.
One way or another expect a new npm release with this issue patched within 24hrs.
from sass-loader.
I've published [email protected] that should address the issue raised by @justin808 .
from sass-loader.
I posted a fix to sass-loader to reference my own fork of sass-graph.
However, sass-graph just fixed my reported issue.
Please comment in this issue when this version sass-loader is updated to this version of sass-graph.
from sass-loader.
Did latest version of sass-graph fixed your issues ?
Then we can update sass-loader and make an npm release.
from sass-loader.
I've just published a [email protected] which passes the test case added by @justin808 .
from sass-loader.
@akiran Can we update sass-loader? I just submitted a PR, albeit a very simple one, to update the version dependency.
from sass-loader.
Fixed?
from sass-loader.
We don't depend on sass-graph anymore.
from sass-loader.
Related Issues (20)
- Add support for node-sass v8 to release v10 branch HOT 6
- I have this issue in project. what should i do please tell i am stuck in this problem HOT 3
- Angular 15 dependencies issue with bootstrap
- SassError: expected "{" HOT 2
- Custom importer in `modern` api mode may cause `ERR_INVALID_URL_SCHEME` error. HOT 4
- [Windows]: [email protected] will throw a python not found error HOT 36
- VueJs is not compiling parent selector HOT 1
- Document outputStyle is set to compressed in production mode HOT 4
- Styles for styles.scss block is not defined HOT 1
- Custom sass functions suddenly do not work? Or the API has changed? HOT 1
- Node Sass 9.0.0 HOT 1
- Before publish to npm , 'prepare' scripts should be removed HOT 15
- Potential Security Vulnerabilities Detected in Package
- error HOT 2
- SCSS Not compile functions properly.
- Missing version upgrade/migration guides HOT 1
- Use the Sass Compiler API HOT 4
- Update v10 to allow use node-sass@9 HOT 3
- Unable to use meta.get-mixin to pass mixin as a value to another mixin, then use it in its content. HOT 2
- v10.5.1 still not support node-sass 9 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sass-loader.