Git Product home page Git Product logo

Comments (6)

alexander-akait avatar alexander-akait commented on June 12, 2024 1

You can't use default as a class name, it is a limitation, because we have default export in ECMA modules, we need to document it

from css-loader.

alexander-akait avatar alexander-akait commented on June 12, 2024 1

Fix - #1590, I improved logic and now we rename default class to _default automatically to avoid crash, also updated docs

from css-loader.

alexander-akait avatar alexander-akait commented on June 12, 2024 1

Anyway I added test case with:

{
  test: /\.module\.css$/,
  use: [
    'style-loader',
    {
      loader: 'css-loader',
      options: {
        modules: {
          exportLocalsConvention: 'as-is',
          namedExport: false,
        },
      },
    },
  ],
}

And can't reproduce the problem, maybe you forget to apply these options in another place

Anyway feel free to feedback (or provide reproducible test repo)

from css-loader.

EvHaus avatar EvHaus commented on June 12, 2024

@alexander-akait Thanks for making that change. Can you help me understand why this change was made in v7? Since a CSS Modules file is returned as an object I don't understand how a class called default would ever conflict with any ES keywords. It worked just fine in v6.

I would understand if the class name was something like .isPrototypeOf or .constructor, but .default isn't one of the reserved keywords for JS objects:

Screenshot 2024-04-11 at 1 23 09 PM

from css-loader.

alexander-akait avatar alexander-akait commented on June 12, 2024

You should not have problems with namedExport: false,, I added test and all everything fine, maybe you have more loaders/plugins, can you create minimum reproducible test repo?

from css-loader.

EvHaus avatar EvHaus commented on June 12, 2024

Ah, you're right. My bad. I saw the docs still said .default gets remapped to _default, but it's not the case with namedExport: false.

from css-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.