Comments (5)
Should we create a new MetricValueHandler and specify in the configuration which fields should be imported as metric or could we implement the "array data" handler in AttributeValueHandler?
In addition, if we choose the first choice, how could we let the metric attributes be handled only from MetricValueHandler and not also from AttributeValueHandler?
from syliusakeneoplugin.
Good point. I think it should be the second choice. Currently all the value handlers naming and concept is based on where the data will be stored on Sylius rather than the attribute type on Akeneo.
With this concept in mind a "MetricValueHandler" should store data in some sort of metric data structure on Sylius. There's no such data structure on Sylius. So we have to think where we want to store, on Sylius, those Akeneo's metric attribute values.
One solution could be to store metric attributes values (and also price attributes values) in Sylius text attributes by concatenating the value with its measurement unit (or with its currency for price attributes).
What do you think @lruozzi9? And you @fabianaromagnoli?
from syliusakeneoplugin.
Good point. I think it should be the second choice. Currently all the value handlers naming and concept is based on where the data will be stored on Sylius rather than the attribute type on Akeneo.
This is true for all ValueHandlers except FileAttributeValueHandler.
One solution could be to store metric attributes values (and also price attributes values) in Sylius text attributes by concatenating the value with its measurement unit (or with its currency for price attributes).
Yes, I think that this is a good solution.
from syliusakeneoplugin.
This is true for all ValueHandlers except FileAttributeValueHandler.
Yes you're right... Probably, a better name of FileAttributeValueHandler
should be something like RawFileValueHandler
. Indeed, currently, if you have an image attribute on Akeneo and you want to store it as a raw file on Sylius you can use the FileAttributeValueHandler
. So the FileAttributeValueHandler
it's not necessary tied to an Akeneo file attribute.
from syliusakeneoplugin.
What I think we could implement is a service "MetricAttributeHandler" or "MetricValueHandler" (the second would be more correct, but I think it could create confusion). This service handles the metrical attributes in AttributeValueHandler and other ValueHandler like PriceValueHandler and when necessary, could be implemented by the user to manage metric attribute as needed.
from syliusakeneoplugin.
Related Issues (20)
- Fix roave BC check
- Use new Symfony bundle directory structure HOT 1
- [BUG] - Import Akeneo boolean attributes in Sylius select attributes
- [BUG?] - Variant images not removed
- Clean attributes by inline style HOT 1
- Consume AttributeOptions message before Product HOT 1
- V2 - Dispatch event with SearchBuilder arguments to allow edit filter query on Akeneo PIM HOT 1
- Add an attribute for each value handler in feature tests
- Import feedback system HOT 1
- [BUG] - If you are using two concurrency messenger consume process you will get an error while importing files HOT 1
- [BUG] - Changing family variant on Akeneo product will break the import of the product
- [BUG] - Option value duplicated on deleted product on Akeneo
- [BUG] - Duplicated option values on Sylius for the same variant
- Dispatch pre/post create/update events for product variant
- Import/update Sylius product option values
- [BUG] - FileAttributeValueHandler does not download files for all locales when attribute has value per locale in Akeneo
- Import attribute translations
- [BUG] - The webhook import dispatch does not consider filters applied on import command
- [BUG] - Product without any product translation will fail on post create event
- Import new select attribute options while importing products
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from syliusakeneoplugin.