Git Product home page Git Product logo

Comments (9)

mmenozzi avatar mmenozzi commented on August 28, 2024

Hi @benjaminpick, sorry for late reply...
Thank you for your feedback. For development purpose we prefer to have unlimited memory at PHP level. As you already understood memory limit should be set at container level.

from docker-php-apache-base.

benjaminpick avatar benjaminpick commented on August 28, 2024

from docker-php-apache-base.

mmenozzi avatar mmenozzi commented on August 28, 2024

Thank you @benjaminpick, I've got your point but I think that the real solution is to have a PHP ini config file loaded from the outside of the container.
In an ideal world users of this container should be able to specify their preferred PHP ini configuration. You've got a problem with memory_limit but another user could experience other issues which requires to adjust other ini settings. Isn't it?
What do you think? Would you like to propose a PR to achieve this?

Let us know.

from docker-php-apache-base.

benjaminpick avatar benjaminpick commented on August 28, 2024

Well, yes of course.

But loading a file from outside seems to defeat the containering
concept. Maybe adding it as a variable?

Am 10.10.2016 um 17:53 schrieb Manuele Menozzi:

Thank you @benjaminpick https://github.com/benjaminpick, I've got your
point but I think that the real solution is to have a PHP ini config
file loaded from the outside of the container.
In an ideal world users of this container should be able to specify
their preferred PHP ini configuration. You've got a problem with
memory_limit but another user could experience other issues which
requires to adjust other ini settings. Isn't it?
What do you think? Would you like to propose a PR to achieve this?

Let us know.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAO7PitV2_7GMjvFMaSn3PB1-lfSS7ZZks5qyl9zgaJpZM4KL08X.

from docker-php-apache-base.

mmenozzi avatar mmenozzi commented on August 28, 2024

Yes it's true, it breaks the containering concept but with a single environment variable you can only set a single ini setting (for example memory_limit). What about if someone wants to change other ini settings (error_reporting, display_errors, ecc...)?

from docker-php-apache-base.

benjaminpick avatar benjaminpick commented on August 28, 2024

That's what I thought at first as well - but YAML supports multi-line
text. It should work with docker-compose, but my tests failed ... let's
see if SO can shed some light on this:

http://stackoverflow.com/questions/39963838/how-can-i-pass-a-multi-line-variable-to-a-docker-container

Am 10.10.2016 um 18:44 schrieb Manuele Menozzi:

Yes it's true, it breaks the containering concept but with a single
environment variable you can only set a single ini setting (for example
memory_limit). What about if someone wants to change other ini settings
(error_reporting, display_errors, ecc...)?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAO7PuQb9gBgK7ObzgXDWHTEEjY42teGks5qymtzgaJpZM4KL08X.

from docker-php-apache-base.

mmenozzi avatar mmenozzi commented on August 28, 2024

Ok, let us know! Thank you!

from docker-php-apache-base.

benjaminpick avatar benjaminpick commented on August 28, 2024

The SO hinted me that multi-line variables do work, I only forgot the
quotes in the shell. So I will send a pull request for this later ...

Am 11.10.2016 um 08:33 schrieb Manuele Menozzi:

Ok, let us know! Thank you!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAO7PuNikrD8ImUN0_jM1OZcsk1JQkMiks5qyy2sgaJpZM4KL08X.

from docker-php-apache-base.

mmenozzi avatar mmenozzi commented on August 28, 2024

Thank you!

from docker-php-apache-base.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.