Remove install_package for ezxml about mx HOT 4 CLOSED

I've been working on this, you can see a branch which doesn't export or install ezxml and links privately here https://github.com/p-groarke/mx/tree/cmake_phase2

However, you have a bigger problem. Mx does indeed export ezxml symbols through its ABI. You can check with a symbol printer tool. On Windows, DUMPBIN /SYMBOLS, on macOS I believe it is nm or otool, not sure what options you give it.

The best way you can test and debug this, is to make a new project that uses and links to mx (a completely seperate project). Until you hide those symbols, you cannot remove ezxml from your install targets.

Note that this is exactly the sort of problem modules in c++20 are trying to fix.

Here are some ideas : make ezxml a header only library. Don't make ezxml a library at all.

from mx.

I have a fix for this that I'll open a PR with soon. I can see how some vestiges in the cmake file probably made this confusing. With my PR, cmake will treat all of the code as belonging to mx and I think it should fix the install_package issues.

One thing that would be very valuable would be to create a self-contained example binary, similar to the existing MxRead and MxWrite examples. But this one should have its own CMake file that relies on find_package Mx. Then in the CI runs we can add a stage that installs Mx and then builds the example to ensure that Mx can be used from a project that uses find_package( Mx ).

Also, I think while we're thrashing around it would be nice to rename the project from Mx to mx. But it's not important.

from mx.

If you have a chance, do a review of #79
It's dumb that the Github UI doesn't let me directly request a review. I hope they add the feature of being able to request a review from any username.

from mx.

Sounds great. I'll rebase over that and see if everything is still ok for my "consumer" project. Probably next w-e or something. If anything I did in my cmake branch makes sense, I'll send a pr just for that (configure_file for example is nice) :)

from mx.