Git Product home page Git Product logo

Comments (5)

wswebcreation avatar wswebcreation commented on June 9, 2024

@colinrotherham

Thanks for the ticket, I never thought about NodeJS 8, was assuming that people would not use it anymore because it's not supported anymore.

I've installed NodeJS 8 on my machine and this was my log

image

Can't you use it now anymore? If So I will revert the packages

from visual-testing.

colinrotherham avatar colinrotherham commented on June 9, 2024

@wswebcreation Sorry no, it's completely broken on Node.js 8 😭

Anyone else on Node.js 8 that runs npm install or npm update will also pull in the unsupported breaking changes from fs-extra, chalk and universalify packaged with the v1.13 releases.

Ideally all v1.13 releases should be marked as deprecated and a new v2.0 release added, otherwise anyone else on Node.js 8 will automatically roll onto the new packages via semver too.

[email protected] # Node.js 8+
[email protected] # Node.js 8+
[email protected] # Node.js 8+

[email protected] # deprecated!
[email protected] # deprecated!
[email protected] # deprecated!
[email protected] # deprecated!
[email protected] # Node.js 8+ (downgraded packages)

[email protected] # Node.js 10+

We're aiming to move off Node.js 8, and we're happy to stay on v1.12 for a while.

If anyone else has this problem you'll need to pin the install to prevent updates, but npm outdated will still flag v1.13 as an available minor release.

npm install [email protected] --save-exact

from visual-testing.

wswebcreation avatar wswebcreation commented on June 9, 2024

Hi @colinrotherham

Because it's not a breaking change for everybody (at least from what I hear and see) I didn't release a V2, but created a patch that fixes this, see https://github.com/wswebcreation/wdio-image-comparison-service/releases/tag/v1.13.4

Reason for this is also that you will now have all the latest fixes of the core, with NodeJS 8 support. I've tried it on my machine and I didn't got any errors. Can you also verify it on your machine and if it is fixed close this issue?

from visual-testing.

colinrotherham avatar colinrotherham commented on June 9, 2024

@wswebcreation That's great, it's all working again now 🎉

Can you npm deprecate the ones that didn't work with Node 8 just in case anyone else tries to install them? Then if you need to bump them back up again start version 2.0.0 😊

Thanks again

from visual-testing.

stale avatar stale commented on June 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from visual-testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.