Unsized imports array in wasm_instance_new. about wasm-c-api HOT 2 CLOSED

The length is given by the module parameter. Both the caller and the callee of course need to be aware of the import signature of the module. There is no scenario in which one can reasonably call this function without knowing what the module imports are, both their number and their types. So a caller usually has to look up wasm_module_imports anyway.

The fact that a caller violating a function's contract can lead to undefined behaviour in the callee is standard situation in C. Duplicating information in the parameter list does not change that, it merely creates redundant work for both sides to provide/check it.

from wasm-c-api.

That's a fair expectation (namely that the imports would need to be resolved anyway prior to instantiation), so it's unlikely that there would be a mismatch in normal usage. And providing a length can't prevent undefined behavior anyway (correct length, incorrectly allocated array for example), so I agree it's redundant even if it doesn't initially appear so when examining the function signature.

I'll close this issue as won't fix. Thanks!

from wasm-c-api.