Git Product home page Git Product logo

Comments (6)

sbc100 avatar sbc100 commented on July 26, 2024 1

Yeah, I'd be interested in seeing what happens if we apply that...

I don't think we want to be applying that to existing code, since we are mostly a fork of musl and we dont want to introduce extra deltas for this kind of thing. For new code it seems reasonable enough as long as its true that the kernel style and musl style do indeed mostly align.

from wasi-libc.

sbc100 avatar sbc100 commented on July 26, 2024

I think for files that come from upstream musl its best to stick to the upstream style of the musl codebase. I doubt this style is covered by a pre-existing config so you might have to role your own, using a pre-existing as a starting point.

For completely new downstream files I guess we could go a different direction, but maybe its better to just have once style everywhere?

from wasi-libc.

dicej avatar dicej commented on July 26, 2024

Yeah, I guess we should avoid creating yet another style for new code and instead try to match one of the existing ones, e.g. the musl one.

from wasi-libc.

sbc100 avatar sbc100 commented on July 26, 2024

The GNU style might be a good starting point: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#basedonstyle ?

from wasi-libc.

dicej avatar dicej commented on July 26, 2024

https://wiki.musl-libc.org/coding-style says:

The best short description of the coding style used in musl is “very similar to the Linux kernel style”.

... so maybe we should start with https://github.com/torvalds/linux/blob/master/.clang-format

from wasi-libc.

abrown avatar abrown commented on July 26, 2024

Yeah, I'd be interested in seeing what happens if we apply that...

from wasi-libc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.