Building with hardening build flags about wasi-libc HOT 4 CLOSED

This results in undefined reference later, however when I try to add the relevant musl sources into the build:

    $(LIBC_TOP_HALF_MUSL_SRC_DIR)/env/__stack_chk_fail.c \

the build complains about missing SYS_futex. Oh right, because musl's stack guard implementation is per-thread, but WASI doesn't support that at the moment. So I suppose the proper fix would be to implement a non-threaded version of this stack guard.

from wasi-libc.

The warning flags should work as expected.

-fstack-protector is indeed not implemented yet, and yes, you may be right that all that's needed right now is a non-threaded implementation. That said, the -fstack-protector feature is not nearly as important on wasm as it is on typilcal native platforms because wasm's callstack is outside of the program address space, so it's never possible to clobber a return address on the stack.

-Wl,-z,relro isn't yet meaningful on wasm, since we don't have dynamic linking yet, and depending on how dynamic linking ends up working, relro may not be needed.

from wasi-libc.

Thanks for confirming! For now I'll just append the -fno-stack-protector flag then, this seems to work OK and nothing is broken.

from wasi-libc.

Closing as answered; feel free to reopen or file a new issue if there are further questions!

from wasi-libc.