Marker Detection problem in new versions about jsartoolkitnft HOT 8 CLOSED

I uploaded 2 videos to show the versions difference clearly. Although in the newer version, the performance is better when the video gets tracked, but the start of tracking itself, is much worse. In the older version the image, starts to track very faster in a more far distance, but in the newer one, you have to place the camera much closer to the marker, or it doesn't track at all.
0.9.7 version: Link
1.6.0 version: Link

from jsartoolkitnft.

Thanks for your response @kalwalt . I will check them tomorrow. I thought the start of tracking markers, happen in kpmMatching function, but I had no luck to find the difference that caused this problem.

from jsartoolkitnft.

I built the WebARKitLib project with the previous Eigen library and still no luck. The behavior is same as before, so the Eigen lib update cannot be the cause of problem. The point that I mentioned before, that the marker gets detected easier at the top of the video frame, gives some guides, and also getting camera closer to marker, causes that a part of marker be placed at the top of the frame. With this reasoning, I think the this issue is due to memory allocation. The comparison of video frame and the markers, just happen at the top of frame, that means the process of comparison only takes place at the beginning part of the frame vector. I still haven't verified the size or allocation of arrays, or compared this in the older and newer versions.

from jsartoolkitnft.

@kalwalt I think I found the main problem. The definition of videoLuma size in ARControllerNFT file (and the similar ones) had an extra 1/4 division. I omitted the division and the behavior got back to normal. I also made a PR on this one.

from jsartoolkitnft.

@kalwalt I think I found the main problem. The definition of videoLuma size in ARControllerNFT file (and the similar ones) had an extra 1/4 division. I omitted the division and the behavior got back to normal. I also made a PR on this one.

@MasoudShah i will review you PR thank you for this!

from jsartoolkitnft.

@MasoudShah Thank you for this, comparing the code of 0.9.7 and 1.6.0 the changes in the code that could affect this, i think the Eigen upgrade in WebARKitLib, and maybe the OneEuroFilter (OEF) routine. Have you tried to disbale the OEF?

from jsartoolkitnft.

I checked it out @kalwalt . Disabling OEF only increases the noise of the video plane, but no effect on start of tracking. I don't know if I'm correct or not, but I feel that the position of the marker has some effect. For example when the marker is at the top of the camera frame, the tracking starts easier; but when it is at the bottom, you have to place the camera too close to the marker to get tracked.

from jsartoolkitnft.

closing because solved with #352 and #353

from jsartoolkitnft.