Git Product home page Git Product logo

Comments (1)

davidcr01 avatar davidcr01 commented on June 10, 2024

Hello.

In bash, = and == are synonyms. However, the = operator should be used with the test commando for POSIX compliance. Which shell are you using?

I tested this behavior in my machine and no difference was found:

The test, test.sh file:

set -x
FILEBEAT_TEMPLATE_BRANCH=5.0.0

WAZUH_MASTER_VERSION="$(curl -s https://raw.githubusercontent.com/wazuh/wazuh/master/src/VERSION | sed -e 's/v//g')"

echo "${WAZUH_MASTER_VERSION}"


if [ "${FILEBEAT_TEMPLATE_BRANCH}" = "${WAZUH_MASTER_VERSION}" ]; then
  echo "They're equal"
else
  echo "They're not equal"
fi

First execution, with == operator:

$ bash test.sh
+ FILEBEAT_TEMPLATE_BRANCH=5.0.0
++ curl -s https://raw.githubusercontent.com/wazuh/wazuh/master/src/VERSION
++ sed -e s/v//g
+ WAZUH_MASTER_VERSION=5.0.0
+ echo 5.0.0
5.0.0
+ '[' 5.0.0 == 5.0.0 ']'
+ echo 'They'\''re equal'
They're equal

Second execution, with = operator:

$ bash test.sh
+ FILEBEAT_TEMPLATE_BRANCH=5.0.0
++ curl -s https://raw.githubusercontent.com/wazuh/wazuh/master/src/VERSION
++ sed -e s/v//g
+ WAZUH_MASTER_VERSION=5.0.0
+ echo 5.0.0
5.0.0
+ '[' 5.0.0 = 5.0.0 ']'
+ echo 'They'\''re equal'
They're equal

Anyway, we will discuss this with the team and see if we need to change the operator or not.
Reference: https://www.gnu.org/software/bash/manual/html_node/Bash-Conditional-Expressions.html

from wazuh-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.