Enhancement: integration with Google Play Game Services about pixel-dungeon HOT 17 CLOSED

That would be awesome! +1

from pixel-dungeon.

+1, but @watabou is never here...

from pixel-dungeon.

Is it possible that he posted the code so that others might make the attempt to add features to the game instead of just asking?

from pixel-dungeon.

Sharing ideas is part of the process. What if I have a great idea but no time nor capacities to implement it?

from pixel-dungeon.

@clemp6r I agree completely, sharing ideas is a great thing and I'm not disparaging that. My comment was more geared towards this bubbling theme that @watabou "is never here" and instead of people constantly pointing this out, they should consider providing feedback or code to assist in the endeavor.

After re-reading my post, it does appear that I was not stating that clearly and that I was more against people asking for things in general, this was not my intention.

from pixel-dungeon.

👍 too
Could be a great feature.

from pixel-dungeon.

+1
I don't know if you will have to wipe the current achievements, but I lost them already 2 or 3 times by flashing my phone, and that's not going to stop me. I think for most fans that's also going to be yet another excuse play again.

from pixel-dungeon.

Can I be the first to say -1? I only have F-Droid installed, and not any Google services on my phone. Recently this game was built for F-Droid, and I thought "Wow, it's really great to see a awesome high quality game that is also open source."

In order for Google serivces to be used, the game will no longer be able to be licensed under the GPLv3 license, and also people like myself who choose not to have Google services installed will be in a sad place with not many high quality games available.

I realise this is my choice to put myself in this situation, but I think it would be a shame if this feature was to be implemented.

from pixel-dungeon.

@pserwylo > You mean you can't use Play Games lib and stay under GPL license ?

from pixel-dungeon.

I believe if you already distribute the game through Google Play, don't see why it could not use the Google Play Services in this particular case. For those who don't use Google Play to install, I think is valid not have the Services as dependency.

And there is the issue of licensing.

from pixel-dungeon.

@PerfectSlayer - As far as I'm aware, all of the Google libraries (e.g. Maps, Play Services, and probably Play Games) are prorprietary. This means that they are incompatible with the GPL, and hence require an exception in the license of pixel dungeon (https://www.gnu.org/licenses/gpl-faq.html#GPLIncompatibleLibs).

@vndmtrx rightly points out that it is possible to have two versions with different dependencies. The best way to do this is likely through "build recipies" - one with Google services and one without. The second best option is for F-Droid to patch out the dependency before building - however this sometimes causes breakage as there is not many developers able to test and maintain such a patch.

from pixel-dungeon.

Google Play Games integration is now there to sync the badges between devices, and that's great. Thank you very much @watabou.

How about integrating them to the metagame thing, with achievements and account XP on the Google play account?
I also don't know what it takes to activate the discovery in the Play Games app, searching for 'pixel dungeon' there doesn't return anything relevant.

I don't know what that would mean regarding F-Droid though...

from pixel-dungeon.

Definitely, some way to compete with friends for score would improve the replayability. Google play already provides the framework, and we already have integration with it for saving the achievements. Just go one step forward.

from pixel-dungeon.

Great addition @watabou! +1

from pixel-dungeon.

Since this is done can we close this issue?

from pixel-dungeon.

I believe so @anubiann00b.

from pixel-dungeon.

So, was this added to the source code in this repository?

from pixel-dungeon.