Git Product home page Git Product logo

Comments (6)

sprankhub avatar sprankhub commented on June 16, 2024 1

Thanks for the info, @navarr. Given that it is a one-time change, I'm fine with it. More important to make the switch to docker compose v2 :)

from warden.

sprankhub avatar sprankhub commented on June 16, 2024

Since quite some users seem to bump into this, I think this should have high priority 🙈 Also, according to https://docs.docker.com/compose/compose-v2/#differences-between-compose-v1-and-compose-v2, it could be as easy as replacing docker-compose to docker compose without any additional changes:

The compose command in the Docker CLI supports most of the docker-compose commands and flags. It is expected to be a drop-in replacement for docker-compose.

Do you see any specific things to watch out for, @navarr? If not and you do not get to it, I'd consider sending a PR.

from warden.

navarr avatar navarr commented on June 16, 2024

@sprankhub I thought there were. I previously did this in Den but I only see the one commit, so I've ported that over in #631

If you have the capability to test this particular issue, I'd appreciate some additional eyes on it.

from warden.

sprankhub avatar sprankhub commented on June 16, 2024

@navarr, sorry for the late feedback. I've installed the docker-compose-plugin branch from the PR to /opt/warden and ran /opt/warden/bin/warden env pull && /opt/warden/bin/warden env up --force-recreate. From the fancier output, I can tell that indeed, docker compose v2 is used. The project still seems to run fine, so I think we are good. Could you merge and release a new version soonish? Looks like there were quite some people affected by this. Thanks!

from warden.

sprankhub avatar sprankhub commented on June 16, 2024

@navarr, I found something. Previously, the containers were named like this:

{{PROJECT_NAME}}_php-fpm_1

Now, the containers are named like this:

{{PROJECT_NAME}}_php-fpm-1

So the number is separated with a dash instead of an underscore.

I am not totally sure if this is really related to the docker compose update or related to an update from 0.12.x to 0.13.x. Anyway, it would be rather bad if the container names change as quite some configuration relies on that.

from warden.

navarr avatar navarr commented on June 16, 2024

@sprankhub unfortunately that's docker compose v1 vs v2. I can do some research to see if we're stuck with it or not but so far I've always presumed so

from warden.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.