Comments (4)
A bit of a me too, but I find the single value check questionable for any field, not just scalars, and had it get in the way before when I was trying to have the parent object take the form of a Datomic lookup ref like [:user/id "mszajna"]
.
I suppose the reason we need this check is that Clojure is really permissive and (= (get [] :field) nil)
instead of exception. This is particularly annoying for default resolvers (everything just silently nils out), but in this particular case the check could be moved to the default resolver itself. In case of user-defined resolvers it should be easy enough for the developer to spot the problem imho.
from lacinia.
If this is a common problem, then it may be possible to defeat those checks with a schema compilation flag. It does mean that other programming errors will become harder to track down, but I think the problem of resolvers returning incorrect arity (single value vs. seq of values) is a minor one.
from lacinia.
I'm going to think about this for a bit first.
from lacinia.
The :disable-checks?
schema compile option can be enabled (it is false by default); it removes the check that ensures that a single value is returned from a resolver that is not a list type.
This option was introduced for performance reasons, but should work well in your case, where a scalar type is, in fact, a seq or set. Of course, you'll need to provide :parse and :serialize for your scalar type that understands what to do.
from lacinia.
Related Issues (20)
- Swallowed unhandled exceptions because of misusage of clojure.core/future HOT 10
- ::lacinia/null returned in unions instead of null HOT 1
- Apollo Federation Compatibility HOT 1
- Includes variable-definitions in parsed query HOT 4
- Question: Is there a way to return JSON without a corresponding EDN definition? HOT 3
- Use of executor/selection in streamer functions HOT 1
- Document example of a raw JSON scalar
- cryptic errors when input is the wrong type
- Passing in variables wrapped in an array comes in as a double array HOT 5
- Support @defer and @stream directives
- Convert the keys of arguments and variables to kebab-case HOT 1
- Subscriptions may fail to stream data to the client
- Unbalanced braces in queries not causing parse-query to fail
- Tracing "validation" fields are always null
- Question: Query complexity and depth HOT 2
- Replace antlr4 deps with antlr4-runtime HOT 2
- Issue with merging fragments with list
- Adding support for deprecation on input fields
- Subscriptions do not maintain ordering HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lacinia.