wal-push .history file and error S3: ObjectNotFound about wal-g HOT 9 CLOSED

No problem, thanks for keeping an eye on possible bugs. Together we make reliable systems :)

from wal-g.

Uhm, thanks for spotting this problem. The code is far from perfect.
1.

tracelog.ErrorLogger.Println("download storage file fail: error:", err)
This logging is superflous, it is expected behaviour that file is absent. Why print this as an error?

2. We had implicit contract that download should return ArchiveNonExistenceError. This contract is broken. We should not mask this with checking error message, but instead find why, when and where it was broken.

from wal-g.

Anyway, PR fixing this would be greatly appreciated. It's definitely a bug. I suspect this reproduces when object is not compressed or is not encrypted.

from wal-g.

2. We had implicit contract that download should return ArchiveNonExistenceError. This contract is broken. We should not mask this with checking error message, but instead find why, when and where it was broken.

you're welcome, I'm just pointing out the problem in code， Looking forward to your updates

from wal-g.

I've created PR with potential fix. Can you please try if this helps?

from wal-g.

uhhm...nope, sorry, that does not fix anything. I have to dig deeper...

from wal-g.

What storage do you use? It seems to me you get non-standard response code. And it is not parsed correctly here.

from wal-g.

isAwsNotExist

sorry, I found it' my fault, I use MinIO as Storage but I found that our internal middleware does a layer of encapsulation of the standard S3 interface，some error has been wrapper by internal handle.

I'm confirming this.

thank you for your reply so much

from wal-g.

sorry again， it's my fault， error has been replace by internal middleware, we fixed it , thank you again

from wal-g.