Comments (9)
No problem, thanks for keeping an eye on possible bugs. Together we make reliable systems :)
from wal-g.
Uhm, thanks for spotting this problem. The code is far from perfect.
1.
tracelog.ErrorLogger.Println("download storage file fail: error:", err)
This logging is superflous, it is expected behaviour that file is absent. Why print this as an error?
- We had implicit contract that download should return ArchiveNonExistenceError. This contract is broken. We should not mask this with checking error message, but instead find why, when and where it was broken.
from wal-g.
Anyway, PR fixing this would be greatly appreciated. It's definitely a bug. I suspect this reproduces when object is not compressed or is not encrypted.
from wal-g.
2. We had implicit contract that download should return ArchiveNonExistenceError. This contract is broken. We should not mask this with checking error message, but instead find why, when and where it was broken.
you're welcome, I'm just pointing out the problem in code, Looking forward to your updates
from wal-g.
I've created PR with potential fix. Can you please try if this helps?
from wal-g.
uhhm...nope, sorry, that does not fix anything. I have to dig deeper...
from wal-g.
What storage do you use? It seems to me you get non-standard response code. And it is not parsed correctly here.
wal-g/pkg/storages/s3/folder.go
Line 390 in 2e0d92c
from wal-g.
isAwsNotExist
sorry, I found it' my fault, I use MinIO as Storage but I found that our internal middleware does a layer of encapsulation of the standard S3 interface,some error has been wrapper by internal handle.
I'm confirming this.
thank you for your reply so much
from wal-g.
sorry again, it's my fault, error has been replace by internal middleware, we fixed it , thank you again
from wal-g.
Related Issues (20)
- Warning "failed to find uploaded binlog behind " on all backups since upgrade to mariadb 10.11 HOT 2
- WAL-G xtrabackup-push is slow HOT 4
- check-ao-aocs-length command does not read config HOT 1
- binlog-server: Error while waiting MySQL applied binlogs HOT 1
- Questions about 3.0 release HOT 10
- Building for Windows HOT 1
- Greenplum: Restoration GP from a backup with the --restore-only option HOT 4
- CVE-2023-39325 - golang: net/http, x/net/http2: rapid stream resets can cause excessive work
- mysql backup-restore should check architecture
- Guidance on configuring WAL-G for MySQL HOT 1
- --after option for delete retain is throwing a panic error
- Greenplum 7 column c.relstorage does not exist HOT 1
- Question: how to reduce number of full backup ? HOT 2
- miss makezero in slice init HOT 1
- Corrupted Restore (Indexes) on Delta with rating composer HOT 8
- Validation causes too many storage calls in v3.0.1 HOT 15
- Unable to build wal-g libsodium donwload issue HOT 4
- Backups intermittently fail to upload due to "request body too small" error (backblaze s3 storage) HOT 2
- link_libsodium.sh - build fails cause of broken link HOT 1
- rewrite this in rust HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wal-g.