Git Product home page Git Product logo

Comments (5)

wader avatar wader commented on August 28, 2024

The discussion begins here: #157

But i guess it's a bit of a balance, having just one multi-arch image would be quite neat also and very clean and simple for users of the image. So in summary for me i think it's a good idea be allow hacky things inside the Dockerfile to do whatever is needed to produce static binaries but be cautious with complicated things in CI and build env etc?

@wader Maybe it's better to make PR on target libraries for helping them to compile on not only on x86_64 arch instead of hacking the Dockerfile?

Yes that is what i've usually done, file issues or send patch upstream and then maybe do hacks temporary. The things that usually cause issues is the uncommon combination of using musl and linking as static PIE.

To be honest, spawning two parallel universes to build the library on them, looks for me overkill. It's a very interesting challenge for me as an engineer, but it will make things more complicated to maintain.

Think i agree, for now i rather have one Dockerfile for everything with sed-hacks etc then multiple repos or branches. And i don't think it will be a problem as long as we build each arch native or emulated compared to cross compile C code which is usually a mess.

from static-ffmpeg.

pyldin601 avatar pyldin601 commented on August 28, 2024

It started working.

Here's the example of successful run:

https://github.com/myownradio/static-ffmpeg/actions/runs/1823775383

and the workflow file looks like this:

https://github.com/myownradio/static-ffmpeg/blob/master/.github/workflows/build-multiarch-on-spot.yml

Here's the resulting image:

https://hub.docker.com/layers/144179126/pldin601/static-ffmpeg/latest/images/sha256-46cf4f9bceef46483aecadb246187f6324738a532616e9650d941fef85e05c69?context=repo

from static-ffmpeg.

wader avatar wader commented on August 28, 2024

@pldin601 very interesting stuff. Still wonder if it would be possible to package something like this as github action step thingy, like make it nearly transparent compared to using standard docker step containers. And how is that compared to using own action runner hosts

from static-ffmpeg.

pyldin601 avatar pyldin601 commented on August 28, 2024

@wader It's rather an experimenting thing. Not sure what the steps for making it simple as single package of GitHub action should be performed. It's possible to spawn spots with pre-installed GitHub runners and using them for running other steps instead of connecting with SSH. But we still need to perform terraform actions before and after build. Also, AWS has its own limitations and quotes. For example, it limits me how many spots I can spawn per hour(?). And I need to wait a few hours before I can be able to spawn instances again.

from static-ffmpeg.

wader avatar wader commented on August 28, 2024

Closed by #159

from static-ffmpeg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.