Git Product home page Git Product logo

Comments (3)

mgiuca avatar mgiuca commented on August 20, 2024

Hmm I wonder if it's worth debating this. The reason all the attributes of ShareData are optional is that none of them are required, but you are supposed to pass at least one of them. It doesn't actually make sense to call navigator.share({}) so it seems the non-normative rationale there ("This is to encourage API designs that do not require authors to pass an empty dictionary value when they wish only to use the dictionary’s default values.") does not apply.

Although I don't think there's a way to express it in WebIDL, perhaps we could add a check in the share method that "if all fields of the dictionary are not present, reject with a TypeError", to actually force the user to supply at least one argument. Then leave the argument as non-optional.

We would still be in violation of the letter of WebIDL but not the spirit. And in fact omitting the argument would have the same result as passing the empty dict (rejected with TypeError).

from web-share.

foolip avatar foolip commented on August 20, 2024

I agree it's weird when some member is required, but no individual one. This was also the case with getUserMedia, debated in whatwg/webidl#130. whatwg/dom@e4f7faa was also done as a result of that.

Making it optional and explicitly throwing when missing wouldn't actually be possible with the spec equivalent of "custom bindings", as when you get into the prose, Web IDL has already done its thing and created a dictionary for you. The existing error handling will do the right thing, but the message given will be a bit cryptic, unfortunately.

from web-share.

mgiuca avatar mgiuca commented on August 20, 2024

MutationObserver.observe sounds like the same case here. It's an optional argument that will (according to its steps always throw a TypeError if omitted.

This makes no sense to me. If you removed the word "optional" from that IDL, there would be no user-visible changes other than observe.length being 2 instead of 1. So the word "optional" is just a lie...

Making it optional and explicitly throwing when missing wouldn't actually be possible with the spec equivalent of "custom bindings", as when you get into the prose, Web IDL has already done its thing and created a dictionary for you.

I'm not suggesting that my prose throw a TypeError if the dictionary is omitted. I'm suggesting that we throw a TypeError if all fields of the dictionary are omitted. (Implicitly, this would be true if the argument was optional and the dictionary was omitted.) This would be the same situation as MutationObserver.observe.

from web-share.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.