Git Product home page Git Product logo

Comments (2)

mgiuca avatar mgiuca commented on August 20, 2024

I don't think it matters either way. Because I am not parsing a URL string to a URL record, then transmitting the URL record (which would have a blob in the URL parser case). I am serializing the URL record back to a URL string again. So using URL Parser vs Basic URL Parser should be equivalent (blob URLs are implicitly allowed, but we would not transmit the blob object).

URL Parser seemed a bit higher level which is why I went with it. Should I still change to Basic URL Parser?

If you want to disallow blob URLs, I think we need an explicit check for it and throw a TypeError.

from web-share.

domenic avatar domenic commented on August 20, 2024

You're right on both counts; the parser used doesn't matter in this case, and my suggestion doesn't properly disallow blobs.

Probably leaving things scheme-agnostic makes more sense then, if there's no natural machinery for excluding blobs. So yeah, I'll close; thanks for setting me straight!

from web-share.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.