Git Product home page Git Product logo

Comments (6)

mfairchild365 avatar mfairchild365 commented on June 14, 2024

@mcking65 - I started to review the checkbox tests and have the following notes.

  1. The exact path of execution is not always clear. For example, the test "Reading checked checkbox in interaction mode" has two instructions. The first is to put the screen reader into forms mode. The second is to read the checkbox with the supplied commands. This makes sense, however, in order to create consistent, easily understandable, and reproducible results, I think we need an additional step that answers the question 'how did the user navigate to the checkbox'?. In other words, it's missing an instruction that says something like "press the tab key until the first checkbox is focused". Exactly how the user navigated to an element may impact how the element was read. I've seen this in previous versions of JAWS. This is also true for the operation tests. Note that there are situations where keyboard focus may remain on a previous input, while virtual focus is moved to a new input, which can cause some screen readers to convey incorrect information. I believe this was a problem in JAWS 2019 and was fixed in the 2020 version. All of that to say: providing detailed instructions on the path of execution to get to the desired element is pretty important.
  2. Reading mode commands are listed for "Navigating to checkbox in interaction mode." Actually, "Navigating to checkbox in reading mode" describes interaction mode instructions, so I think the names just got swapped.

from aria-at.

mfairchild365 avatar mfairchild365 commented on June 14, 2024

I'll make a PR to add missing navigation instructions and fix test titles

from aria-at.

mfairchild365 avatar mfairchild365 commented on June 14, 2024

Also, virtual is misspelled

from aria-at.

mfairchild365 avatar mfairchild365 commented on June 14, 2024

also change "spoken" to "conveyed"

from aria-at.

mfairchild365 avatar mfairchild365 commented on June 14, 2024

Update: I submitted two pull requests related to the issues outlined here.

However, I also noticed that the number of steps is hardcoded in the test harness.

I think it would still be good to add an instruction like "click the button to open the test page and wait for the first checkbox to automatically receive focus", but I'm not sure about the best way to do that yet given the architecture.

from aria-at.

spectranaut avatar spectranaut commented on June 14, 2024

I think this review has been completed!

from aria-at.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.