Comments (7)
@legostud, can you provide source files? I just need <svg>
elements and their attributes, <svg>
contents are not required.
from gulp-svgstore.
@legostud please provide a test case or I will have to close this as "can't reproduce".
from gulp-svgstore.
@legostud I added the test (that is passing) to this branch: https://github.com/w0rm/gulp-svgstore/tree/51-duplicate-namespaces
from gulp-svgstore.
/cc @ghetolay what do you think of this issue?
from gulp-svgstore.
Well an example would be great because duplicate of attribute names seems very unlikely.
Because we could totally do something wrong on the detect/check of namespace procedure but then the part about adding attribute is very simple :
for (var nsName in namespaces)
$combinedSvg.attr(nsName, namespaces[nsName])
namespaces
being an object it's technically impossible to add the same nsName
twice. And EVEN if we did call attr()
twice with same attribute name it should replace old value not duplicate the attribute.
So this is very odd for me and I have absolutely no idea about how this is possible.
from gulp-svgstore.
@legostud Also quick guess, if it works on gulp-svgstore 5.0.4, and since this version is not adding any namespace, this is probably because you are adding it yourself.
This is maybe why you end up with duplicate namespace on version 5.0.5 : first one added by gulp-svgstore and second one by you.
from gulp-svgstore.
@ghetolay yeah, could be it. Anyway, I am closing this because @legostud is not responding.
from gulp-svgstore.
Related Issues (20)
- Combine svg's to sprite - apply class attribute to symbols HOT 1
- Incredible "fill" attribute HOT 1
- Name and link for html5boilerplate visuallyhidden class is obsolete in README
- Options for including title and desc tags
- Rendering issues due to <svg> style not being trasferred HOT 3
- css-what dependency is vulnerable to Denial of Service HOT 1
- Fork or pull request for migrate to stack? HOT 2
- Apply class attribute to symbols HOT 1
- "viewBox → viewbox" is bad HOT 5
- <def><style> stops fill: anycolor HOT 3
- defs included outside the symbol HOT 5
- Defs cleanup?? Defs are missing after running svgstore HOT 1
- gulp4 alpha.3 HOT 3
- Styling individual paths through css HOT 1
- Moving away from the Buffer constructor HOT 2
- Content loaded via ajax shows empty icons HOT 3
- UnhandledPromiseRejectionWarning when more than one SVG in the source directory HOT 1
- Problem with globs HOT 2
- Update README to propose automatic fix for `clipPath` issues HOT 1
- No preview files available HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gulp-svgstore.