Git Product home page Git Product logo

Comments (5)

vysheng avatar vysheng commented on July 24, 2024

Could you provide example? I always use 64-bit systems, should be safe

from tgl.

lkraider avatar lkraider commented on July 24, 2024

For example, on queries.c, everywhere when this is done:

packet_ptr - packet_buffer

there is a warning Implicit conversion loses integer precision: 'long' to 'int', since a pointer is a long in 64bit systems.

from tgl.

vysheng avatar vysheng commented on July 24, 2024

Yes, I understand, but of cause this is correct, since this length fits into integer. I suggest to disable such warnings as it is too much work to get rid of them (though you were right, there was one bug with msg_id).

from tgl.

lkraider avatar lkraider commented on July 24, 2024

The problem with disabling type warnings for these cases is that they can hide future legitimate errors. I prefer to live with them enabled knowing they are harmless.

from tgl.

nopjmp avatar nopjmp commented on July 24, 2024

It would be better to change all the pointers to intptr_t, that way they are always the right size. This also helps on architectures that define types strangely. (the joys of portable programming)

from tgl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.