Comments (4)
dosssman
commented on August 24, 2024
1
I don't think I can close the issue though
from cleanrl.
vwxyzjn
commented on August 24, 2024
https://github.com/openai/spinningup/blob/038665d62d569055401d91856abb287263096178/spinup/algos/pytorch/ppo/ppo.py#L44-L64 offers better implementation and it matches closer to the GAE described in the paper. Namely,
We will probably push for something similar to that.
from cleanrl.
vwxyzjn
commented on August 24, 2024
Fixed via the latest commit, please close the issue after review (if there is no problem) @dosssman
from cleanrl.
dosssman
commented on August 24, 2024
discount_sum sounds like a safe bet for now
from cleanrl.
Related Issues (20)
- Question about the `noise-clip` parameter in DDPG. HOT 2
- Is is possible for SAC to support gymnasium too as TD3 and PPO ? HOT 4
- Poor Evaluation Performance in PPO HOT 5
- get action in sac_continuous_action.py HOT 2
- [BUG] Different final epsilon and evaluation epsilon for Atari implementations
- expected sequence of length 8 at dim 1 (got 0) HOT 4
- [BUG] Env does not reset when it's terminated HOT 2
- can't upload video running ppo_atari.py,wandb has no data HOT 8
- Why converting observation space to np.float32? HOT 2
- Reproduction util: wrong command path
- Why normarlize advantage only for pg_loss but not for vf_loss? HOT 2
- Contributing PPO + Transformer-XL HOT 3
- clamp in C51
- Gymnasium Version Requirement May Need To Be Updated HOT 1
- Gymnasium and PyBullet envs: Problem with video capture
- Docker image is out of date
- KeyError: 'cleanba_ppo_envpool_procgen'
- Unable to allocate 26.3 GiB for an array HOT 1
- Potential bugs in RecordEpisodeStatistics
- Any usage of poetry after installation: No module named 'tomli' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cleanrl.