Git Product home page Git Product logo

Comments (5)

vvvar avatar vvvar commented on May 28, 2024 1

Hello @yonderehco1197. Thanks for the feedback and sorry for the long delay. Fixed both problems in the v0.8.2.

from peakeater.

 avatar commented on May 28, 2024

For this you would need to implement linear phase oversampling, no? Unless there's a way to do it with minimum phase

Edit: I forgot that you can, the "dry" signal has to have the same phase rotation as the oversampled version though.

from peakeater.

vvvar avatar vvvar commented on May 28, 2024

Hm, then(if i get you right), one of the options could be to mix "dry" and "wet" directly while "clipping" stage, since current flow is kinda like this:
Input Gain -> Oversample(Up) -> Pre-Filter -> Clipper -> Post-Filter -> Oversample(Down) -> Output Gain

from peakeater.

yonderehco1197 avatar yonderehco1197 commented on May 28, 2024

Using the dry/wet parameter in oversampling modes turns the clipper into a comb filter. Still works correctly in default mode.

Perhaps a separate issue should have been created for the next request. I apologise if that is the case. The gist is in the attached image, but I could be wrong and you meant dry/wet as the "last output" of the plugin.
screenshot-mac

from peakeater.

yonderehco1197 avatar yonderehco1197 commented on May 28, 2024

Tested in all possible combinations of dry/wet and oversampling. It works without any problems.
Thank you!

from peakeater.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.