Git Product home page Git Product logo

Comments (3)

vutran avatar vutran commented on May 24, 2024

Contrast ratio is only checked for master components, but not the instances which may contain overridden properties with inaccessible combinations applied. Checking generally against instances (and just frames in general) may be more useful, especially considering Figma librarires functionality

This makes sense. The reason why I chose to limit it to only Components is to enforce fixes be made on the Component itself. The goal is to ensure designers are reusing as much colors/styles/components and expanding this to run against overridden properties otherwise it doesn't truly solve the problem of hundreds of color/style variations. Stated, these overridden properties should actually trigger the prefer-local-styles error.

I couldn't trigger the must-be-in-frame error in my sample file, the rule should be checking all immediate children of the canvas or am I not understanding how that should work?

This is correct. Do mind sharing a gist of a Figma structure that replicates these issues? You should be able to obtain this directly from the API or can just DM me a link to your project and I can take a look at some of these issues.

from dslint.

ichik avatar ichik commented on May 24, 2024

Just take a look at this, it's a simple file with only rectangle on a canvas. If I understand correctly it should trigger must-be-in-frame, but I'm only seeing errors for prefer-local-style.

from dslint.

vutran avatar vutran commented on May 24, 2024

Closing as the provided Figma link is invalid. Please re-open with updated link if the problem still persists.

from dslint.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.