Git Product home page Git Product logo

Comments (10)

antfu avatar antfu commented on May 25, 2024 4

Maybe someone could fork and maintain one that does not include @vue/composition-api - for example, vue-demi-lite? To me, vue-demi is designed to be filling the API difference between Vue 2 and Vue 3, in which @vue/composition-api is necessary.

from vue-demi.

sduduzog avatar sduduzog commented on May 25, 2024

I have a feeling the issue I faced is related to this one #76

from vue-demi.

sevilyilmaz avatar sevilyilmaz commented on May 25, 2024

I'm having the same issue and getting this error.

ERROR in ../../node_modules/vue-demi/lib/index.mjs 2:0-84
Module not found: Error: Can't resolve '@vue/composition-api/dist/vue-composition-api.esm.js' in '[PATH_OMITTED]/node_modules/vue-demi/lib'
resolve '@vue/composition-api/dist/vue-composition-api.esm.js' in '[PATH_OMITTED]/node_modules/vue-demi/lib'

This issue seems fixed before with this commit 559eec6 but it appeared again.

vue-demi: 0.11.3

from vue-demi.

antfu avatar antfu commented on May 25, 2024

It does not make sense to use vue-demi without composition api.

from vue-demi.

sevilyilmaz avatar sevilyilmaz commented on May 25, 2024

In that case, it shouldn't be optional dependency as it's defined here https://github.com/vueuse/vue-demi/blob/master/package.json#L44 unless that's needed for something else

from vue-demi.

antfu avatar antfu commented on May 25, 2024

It's optional because in Vue 3 you don't need that. I think it's clear documented that you need @vue/composition-api to work with Vue 2.

from vue-demi.

sduduzog avatar sduduzog commented on May 25, 2024

@antfu I've gone with specifying in the plugin/s readme that when using Vue 2.x you have to add it, and the nuxt module that depends on it has @vue/composition-api as a devDependency

from vue-demi.

LinusBorg avatar LinusBorg commented on May 25, 2024

@antfu My challenge with this is mainly the auto-install of the plugin-

I know how this plugin initially was created to be able to use use composition API in libraries for Vue 2 and Vue 3 at the same time.

My use case is a bit different. Right now, I'm experimenting with setups in which we can write libraries that use components (SFCs) and build them separately for Vue 2 and Vue 3, "patching" some differences like lifecyle hook names at runtime.

For my usecase, vue-demi is very ueful mostly for being able to differentiate between Vue 2 and Vue 3 and getting a universal defineComponent() function. But developers might not want or need composition API in their library, they might just want to write components in Options API and then build them for Vue 2 and 3.

This would be a usecase for Vue-Demi where @vue/composition-api is only needed for defineComponent, but would not have to be installed as a plugin so the rest can be tree-shaken.

from vue-demi.

LinusBorg avatar LinusBorg commented on May 25, 2024

Fair enough, makes sense.

from vue-demi.

sduduzog avatar sduduzog commented on May 25, 2024

Maybe someone could fork and maintain one that does not include @vue/composition-api - for example, vue-demi-lite? To me, vue-demi is designed to be filling the API difference between Vue 2 and Vue 3, in which @vue/composition-api is necessary.

Will definitely consider this.. But I'll wait until it's a painpoint to at least one user of the package

from vue-demi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.