Git Product home page Git Product logo

Comments (8)

sibbng avatar sibbng commented on May 25, 2024 1

Since Skypack doesn't have any way to override package versions (query variables etc.) I would suggest using jspm and import maps. vue-demi's functionality comes from it's post install hook which is where controls your vue version. In browser doing something like that possible with import maps.

I'm pretty sure you are not working on anything serious, and neither I do. That because I had experienced @vueuse/core + reactivue previously to see how vue-demi works in browser. Here it is: https://focused-williams-cf307d.netlify.app/ You can do CTRL+U for source code. I linked vue to reactivue in this example but in your case you can simply link it to vue 3. For generating import maps https://generator.jspm.io/ could help.

The least thing we could do is to release 3 versions at the same time - vue-demi@latest vue-demi@v2 vue-demi@v3. But not sure if it's worth it at the current stage.

It will also require packages (fluent-vue, @vueuse/core etc) to release under 2 different tags. Since vue-demi isn't supposed to be used in that way it would be an unnecessary effort.

from vue-demi.

antfu avatar antfu commented on May 25, 2024

How could I fix that tho? 👀

from vue-demi.

Demivan avatar Demivan commented on May 25, 2024

Actually I have no idea 😃. Not sure how Skypack decided to import [email protected]
I just tried using my fluent-vue package with Skypack and got ref is not defined. Tracked it down to vue-demi importing wrong vue version.
Maybe changing order in peer dependencies from "vue": "^2.6.0 || >=3.0.0" to "vue": "^3.0.0 || ^2.6.0" will make Skypack load vue@3

from vue-demi.

Demivan avatar Demivan commented on May 25, 2024

But I think no matter what you do Skypack version cannot be compatible with both vue@2 and vue@3

from vue-demi.

antfu avatar antfu commented on May 25, 2024

Maybe changing order in peer dependencies from "vue": "^2.6.0 || >=3.0.0" to "vue": "^3.0.0 || ^2.6.0" will make Skypack load vue@3

I don't mind trying :)

But I think no matter what you do Skypack version cannot be compatible with both vue@2 and vue@3

Yeah, wondering why you need to use it with Skypack tho?

from vue-demi.

Demivan avatar Demivan commented on May 25, 2024

Yeah, wondering why you need to use it with Skypack tho?

I was just messing with it :) Wanted to try it out.
So it is not a big deal if vue-demi is broken there. It shouldn't be a common use-case.

from vue-demi.

Demivan avatar Demivan commented on May 25, 2024

v0.11.1 did not fix it. Going to close the issue. Will create pull request if I figure out how to make it work with Skypack.

from vue-demi.

antfu avatar antfu commented on May 25, 2024

The least thing we could do is to release 3 versions at the same time - vue-demi@latest vue-demi@v2 vue-demi@v3. But not sure if it's worth it at the current stage.

from vue-demi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.