Git Product home page Git Product logo

Comments (7)

antfu avatar antfu commented on May 25, 2024

It was removed because of npm v7 support (#15) and now I am confused about how to make it work for both npm and yarn... Any suggestions?

from vue-demi.

Demivan avatar Demivan commented on May 25, 2024

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta can be used to specify optional peer dependencies. If npm v7 does not install optional peer dependencies it should be correct solution.

from vue-demi.

antfu avatar antfu commented on May 25, 2024

I have added a test script to enum every package manager in #30 but can't repro the problem you are facing. Can you give it a look and see if I have missed anything? (A PR to make yarn berry fails would be greatly appreciated!) Thanks.

from vue-demi.

Demivan avatar Demivan commented on May 25, 2024

Will try to reproduce tomorrow. I was not able to reproduce it on smaller project.
Tests need to be adjusted for yarn@berry. Looks like it is not using berry version at all. Maybe need to call yarn set version berry in test project.
These lines should not work:
https://github.com/antfu/vue-demi/blob/564197f23feff2d058d56b80c9798ac72f5f75dd/.github/test.js#L20
https://github.com/antfu/vue-demi/blob/564197f23feff2d058d56b80c9798ac72f5f75dd/.github/test.js#L27
There is no node_modules folder and to call scripts you need to use yarn node instead of node

from vue-demi.

Demivan avatar Demivan commented on May 25, 2024

After some investigation I was able to reproduce this: https://github.com/Demivan/vue-demi-test

To reproduce with pnpm:

  • checkout pnpm branch
  • pnpm i
  • pnpm test

Fixed version:

  • checkout previous commit or uncomment line in pnpmfile.js
  • rm pnpm-lock.yaml
  • pnpm i
  • pnpm test

To reproduce with yarn:

  • checkout yarn branch
  • yarn
  • yarn test

Fixed version:

  • checkout previous commit or uncomment lines in .yarnrc.yml
  • yarn
  • yarn test

I was not able to reproduce for simpler project because of this https://pnpm.js.org/en/faq#solution-1. Both pnpm and yarn@berry allow packages to access dependencies defined in root project package.json as a fallback.

from vue-demi.

antfu avatar antfu commented on May 25, 2024

Thanks for the repro! I'd like to take this chance to setup the test for each agents and your test repo would definitely help. Will get you back after I have set them up.

from vue-demi.

Demivan avatar Demivan commented on May 25, 2024

I'm going to close this. 559eec6 fixed this issue.

from vue-demi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.