Some questions and suggestions about core HOT 1 CLOSED

Question 1

app.options.themeConfig

But it's not suggested to access themeConfig in plugins, a plugin should only consider it's own options. It should be theme's business to handle themeConfig and set corresponding plugin config.

Suggestion 1

Vitepress has migrated to <script setup>.

Pre-compile the standalone .ts files is a optimization, but a more complete solution cloud be pre-compiling the .vue files with rollup.

However, we currently don't implement it because the pallete support (pallete.styl and index.styl) and the default theme ejection (vuepress eject in vuepress 1, not impelemented in v2 yet).

In addition, typescript is not required as a dependency, because we have migrated to use esbuild-loader.

Suggestion 2

We have supported both module.exports and export default in plugins, so this should not be a problem anymore. You can check out our current plugins.

As for the mix of esm and cjs, yes it is annoying indeed, and that might be one of the reasons that vitepress is not going to support node-side plugins. Our current solution is to create tsconfig.cjs.json and tsconfig.esm.json to handle them.

(Hope the native esm support of nodejs can be enabled universally)

PWA and SEO plugins

I think I would migrate v1 PWA plugin first. Of course contributions are welcome.

Take your exam top priority. OSS is not so important lol.

I'll close this first. Feel free to comment if you have any further ideas

from core.