Fix tslint about ui HOT 21 CLOSED

@pbteja1998 merged. Thank you.

Sorry for hustle, this is kinda bleeding-edge development where sometimes we really don't know how to follow spec and what is best practice :)

from ui.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 150.0 DAI (150.0 USD @ $1.0/DAI) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $152,899.56 more funded OSS Work available on the Gitcoin Issue Explorer

from ui.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 weeks, 2 days from now.
Please review their action plans below:

1) pbteja1998 has been approved to start work.

I would like to work on this issue. I have worked with tslint so many times before and this task seems pretty straightforward. I will complete it in a day if I got approved.

Thanks.

Learn more on the Gitcoin Issue Details page.

from ui.

@yangwao What about no-shadowed-variable, no-unused-expression, no-console ?

These are also present in tslint.json

from ui.

Also why do you want to remove allow-leading-underscore option? This is the most commonly used pattern in typescript when there are getters and setters as var names cannot be same as getter and setter names.

If you still want me to remove this, what do you want me to name the variable names instead of this? Perhaps mVarname (showing that it is a member variable) ?

from ui.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 150.0 DAI (150.0 USD @ $1.0/DAI) has been submitted by:

1. @pbteja1998

@Web3Foundation please take a look at the submitted work:

• PR by @pbteja1998

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $152,077.73 more funded OSS Work available on the Gitcoin Issue Explorer

from ui.

@yangwao @Web3Foundation Can you please get this reviewed?

from ui.

@yangwao @Web3Foundation

from ui.

@yangwao What about no-shadowed-variable, no-unused-expression, no-console ?

These are also present in tslint.json

Yes, we would like to remove these as well. We are in the middle of releasing all packages, so I'm expecting some merges and I think we will be back to it in the begging of next week.

Also why do you want to remove allow-leading-underscore option? This is the most commonly used pattern in typescript when there are getters and setters as var names cannot be same as getter and setter names.

Yes, we are thinking we want to keep it for now. However, we want to follow in the future this tsconfig.json https://github.com/polkadot-js/dev/blob/master/packages/dev/config/tsconfig.json

If you still want me to remove this, what do you want me to name the variable names instead of this? Perhaps mVarname (showing that it is a member variable) ?

Let's stick with keeping rule allow-leading-underscore for now.

Thank you for taking this bounty

from ui.

@yangwao Made all the necessary changes. Also please refer #11 PR. I had some issues with commits in the previous PR. So I made a new PR with new branch.

from ui.

@yangwao I know that you might be busy. This is just a reminder in case you forgot. Please review #11 when you have time. Thanks.

from ui.

@yangwao Any update on this?

from ui.

Hello, we've been merging things from upstream, changes are here polkadot-js/ui@e87647e

@pbteja1998 we just finished releasing version and we won't be touching branch for while. Feel free to adjust your PR, would happy to merge.

from ui.

@yangwao Can you tell me repo/branch that I should merge into my branch(pbteja1998/vue-ui/lnt-fixes-2) and what should I keep as base branch for the PR ?

from ui.

I'll be merging branch vue-keyring, so you can use that one as base branch for PR

from ui.

@yangwao I have adjusted my PR ( #11 )

from ui.

@Web3Foundation Can you please pay out the bounty associated with this.

from ui.

@pbteja1998 yes, I've reached web3foundation representative and they will get back to you soon.

from ui.

@Web3Foundation

from ui.

@pbteja1998 sorry for the holdout; it's being paid out now, there were some very serious congestion issues with the ethereum network last week.

from ui.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 150.0 DAI (150.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @pbteja1998.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $156,247.56 more funded OSS Work available on the Gitcoin Issue Explorer

from ui.