Admin panel crashes when signing in about fastadmin HOT 7 CLOSED

  File "C:\Users\Владислав\PycharmProjects\mitsu_api\virtualenv\Lib\site-packages\fastadmin\api\frameworks\fastapi\api.py", line 329, in configuration
    return await api_service.get_configuration(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Владислав\PycharmProjects\mitsu_api\virtualenv\Lib\site-packages\fastadmin\api\service.py", line 414, in get_configuration
    current_user_id = await get_user_id_from_session_id(session_id)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Владислав\PycharmProjects\mitsu_api\virtualenv\Lib\site-packages\fastadmin\api\service.py", line 62, in get_user_id_from_session_id
    if not user_id or not await admin_model.get_obj(user_id):
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Владислав\PycharmProjects\mitsu_api\virtualenv\Lib\site-packages\fastadmin\models\base.py", line 415, in get_obj
    obj = await self.orm_get_obj(id)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Владислав\PycharmProjects\mitsu_api\virtualenv\Lib\site-packages\fastadmin\models\orms\sqlalchemy.py", line 314, in orm_get_obj
    return await session.get(self.model_cls, id)

from fastadmin.

Investigation:

• we get configuration after sign in to render UI
• we get current_user_id from session (jwt token which we store in http only cookies)
  current_user_id = await get_user_id_from_session_id(session_id) (fastadmin\api\service.py, line 447)

In get_user_id_from_session_id:

    user_id = convert_id(user_id)
    if not user_id or not await admin_model.get_obj(user_id):
        return None

After a fix in 0.1.37 we have convert_id and get_obj should receive int | UUID not string

get_obj -> orm_get_obj (SQL Alchemy orm)

    async def orm_get_obj(self, id: UUID | int) -> Any | None:
        sessionmaker = self.get_sessionmaker()
        async with sessionmaker() as session:
            return await session.get(self.model_cls, id)

from fastadmin.

My suggestion is to change the code >>https://github.com/vsdudakov/fastadmin/blob/f618ac98f8f50f5cddf835139ca626fe6c2e7/fastadmin/api/service.py#L121:
"user_id": str(user_id),
To:
"user_id": user_id,

And add this code before return:

if isinstance(user_id, UUID) :
user_id = str(user_id)

I will try the solution. Thank you!

from fastadmin.

0.1.37...0.1.38
@kuyugama Provided your solution in 0.1.38. Hope it will help.

from fastadmin.

Investigation:

• we get configuration after sign in to render UI
• we get current_user_id from session (jwt token which we store in http only cookies)
  current_user_id = await get_user_id_from_session_id(session_id) (fastadmin\api\service.py, line 447)

In get_user_id_from_session_id:

    user_id = convert_id(user_id)
    if not user_id or not await admin_model.get_obj(user_id):
        return None

After a fix in 0.1.37 we have convert_id and get_obj should receive int | UUID not string

get_obj -> orm_get_obj (SQL Alchemy orm)

    async def orm_get_obj(self, id: UUID | int) -> Any | None:
        sessionmaker = self.get_sessionmaker()
        async with sessionmaker() as session:
            return await session.get(self.model_cls, id)

Converting id to a number after it has been converted to a string is a bad decision. Because you can store id already in the desired data type

from fastadmin.

Agreed but it doesn't work for UUID , could you please check 0.1.38?

from fastadmin.

In case it works I will clean up code and remove convert_id keep it only for UUID may be

from fastadmin.