Git Product home page Git Product logo

Comments (3)

thorroed avatar thorroed commented on June 9, 2024 1

Hi, great! thanks! one more thing in cache.hpp: if the locks are working then there is also a double lock when checking the Size(). I made these changes while sticking to the non-recursive std::mutex mutex type.

         if (elem_it == cache_items_map.end())
         {
             // add new element to the cache
-            if (Size() + 1 > max_cache_size)
+            if (cache_items_map.size() + 1 > max_cache_size)
             {
                 auto disp_candidate_key = cache_policy.ReplCandidate();

from caches.

vpetrigo avatar vpetrigo commented on June 9, 2024

Hello @thorroed,
Thank you for your report. I'll fix that issue.

from caches.

vpetrigo avatar vpetrigo commented on June 9, 2024

Should be fixed in PR #11. Thank you @thorroed once again! 😄

from caches.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.