Comments (4)
Just changed line 216 of params.pp to:
$distrelease = "${::os[release][major]}sp${::os[release][minor]}"
However, there is another problem. The vmware repo URL now redirects to https://, and on SuSE 11.3 the rpm binary can't handle SSL. In other words this doesn't work:
exec { 'vmware-import-gpgkey':
path => '/bin:/usr/bin:/sbin:/usr/sbin',
command => "rpm --import ${gpgkey}",
refreshonly => true,
}
The safe way to make this work is to wget the key first and then import a local file. @razorsedge, what would you recommend for a pull request: adding a wget requirement or using some download_file type module, or some other option?
from puppet-vmwaretools.
@akomakom There should be plenty of modules that implement a file download. No need to re-invent one.
The ::os[release][major]
is that a Puppet 4 facter construct?
Does changing line 216 also work for other SuSE versions?
from puppet-vmwaretools.
@razorsedge I certainly have no plans to roll my own download module, I was referring to puppet/download_file as an example, but upon closer inspection that turns out to be a windows-only module. There are plenty out there.
Your other questions bring up a good point:
hash facts (ie $os[release][major]) are supported in puppet 3 (possibly even in later 2.x), but their use requires puppet.conf setting of stringify_facts = false, which may be an unreasonable expectation for all clients. It becomes the default behavior in puppet 4. Unfortunately, I didn't see the value "3" (from SuSE 11.3) in any other fact. Maybe it's safer to string-replace the fact we have (11.3 -> 11sp3).
The URL structure seems valid for all 11.x and 9.x suse versions:
https://packages.vmware.com/tools/esx/latest/index.html
For 12.x this module doesn't apply anyway.
from puppet-vmwaretools.
I just confirmed that my original change also works for SLES 11.4 (but again, it relies on stringify_facts = false so may not work in some Puppet 3.x deployments).
The change, for clarity, was:
Index: manifests/params.pp
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- manifests/params.pp (revision 3868)
+++ manifests/params.pp (revision 3953)
@@ -255,7 +255,7 @@
'SLES', 'SLED': {
# TODO: tools 3.5 and 4.x use either sles11 or sles11sp1 while tools >=5 use sles11.1
if ($majdistrelease == '9') or ($majdistrelease == '11') {
- $distrelease = $::operatingsystemrelease
+ $distrelease = "${::os[release][major]}sp${::os[release][minor]}"
} else {
$distrelease = $majdistrelease
}
The original problem still remains - you have to perform rpm --import VMWARE-PACKAGING-GPG-RSA-KEY.pub yourself because (at least on some SLES 11.4 installs I have) rpm can't handle being redirected to https.
from puppet-vmwaretools.
Related Issues (20)
- 3.* and 4.* in ubuntu require restricted 'repos' HOT 1
- Dont include ::apt inside module HOT 1
- Could not find init script for 'vmware-tools-services' HOT 1
- RHEL6: Execution of '/sbin/start vmware-tools-services' returned 1 HOT 21
- OEL 5.11, init.pp calls udevadm instead of udevcontrol HOT 1
- vmware source having issues again? HOT 1
- Issues using this with hiera HOT 1
- Is the default yum repo path correct? HOT 3
- RHEL/CENT 7 HOT 1
- puppet-vmwaretools creates blank file at /etc/yum.repos.d/vmware-tools.repo, and everything afterwards fails HOT 1
- Get rid of the warning HOT 5
- Fixes needed for STRICT_VARIABLES HOT 2
- ntp needs disable
- Add support for RHEL 7 and CentOS 7 HOT 1
- autoupgrade requires dependencies to be passed using $package parameter... HOT 3
- File_line[disable-tools-version]: Could not evaluate: can't convert Hash into String HOT 1
- Apt dependency Update HOT 2
- GPG-DSA-KEY has been deprecated HOT 1
- Requires update for Puppet 6/7 Support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-vmwaretools.