apt and yum resources are not listed as dependencies about puppet-nodejs HOT 4 CLOSED

On second thought, I would love to see this at puppetlabs-stdlib, because we would not need to change our modules. But I think the list of modules would be endless:

• puppetlabs-apt
• puppetlabs-mysql
• puppetlabs-postgresql
• puppetlabs-yumrepo_core
• camtocamp-systemd
• stahnma-epel
• ...

from puppet-nodejs.

apt and probably yum falls under the category of a soft dependency https://puppet.com/docs/puppet/6.0/style_guide.html#dependencies and I am strongly against adding them as a hard dependency as it causes all kinds of usability and maintenance issues longer term.

The README does mention puppetlabs-apt, but perhaps now with the removal of things from core, more needs to be listed there as part of a Pull Request.

from puppet-nodejs.

@juniorsysadmin I agree that these modules should not be defined as hard dependency, but maybe we should add the following code to our modules, because not everyone reads the docs carefully:

if $facts['package_provider'] == 'deb' and !defined('apt') {
  fail('Please provide the module puppetlabs-apt')
} elsif $facts['package_provider'] == 'yum' and !defined('yumrepo_core') {
  fail('Please provide the module puppetlabs-yumrepo_core')
}

from puppet-nodejs.

Issue #395 created to add docs

from puppet-nodejs.