Add a dependency for treydock/gpg about puppet-nodejs HOT 6 CLOSED

is that a _hard_ dependency?

from puppet-nodejs.

This isn't hard dependency. In some upcoming pull requests I will get rid of this dependency entirely by using new parameters in yum_repo making Puppet 3.6.x the minimum Puppet version.

from puppet-nodejs.

Aside: gpg_key currently appears to be broken when using Facter 2 or above. treydock/puppet-gpg_key#6

from puppet-nodejs.

@igalic is there any documentation re: metadata.json and hard vs soft dependencies? I just spent some time trying to figure out why we were getting Invalid resource type gpg_key errors, and only discovered this dependency by looking at the source, and at the wayyyyyy bottom of the README.

I'd assumed that if a module was using metadata.json, that would contain all dependencies, period...

from puppet-nodejs.

@jantman http://docs.puppetlabs.com/guides/style_guide.html#dependencies . I wish there was a solution with dependency-sets depending on osfamily, but sadly there isn't at the moment...

from puppet-nodejs.

We could agree to set up a hash of 'indirect dependencies' inside metadata.json. cc @ryanycoleman

from puppet-nodejs.