Comments (8)
👍
from puppet-nginx.
👍
from puppet-nginx.
solution #576
from puppet-nginx.
👍
but I think #576 is a workaround. the module should do it correctly by default, to avoid the wrong behavior, if the DevOP is careless / inexperienced
from puppet-nginx.
I agree. However see @jfryman comment. I do understand his noble democratic desire to allow people doing stupidity but I still think that by default root should be in server block. Case that user from whatever reasons still wants to place root in location block give her/him option to do it.
from puppet-nginx.
@schkovich I totally agree.
from puppet-nginx.
@schkovich I think in that comment I said...
I'd rather provide sane defaults and let a user make silly decisions on their own.
I do think this falls under a sane default. Throw up a PR, I'll review/merge. I was hoping the original author of that PR would rebase/resubmit, but it didn't happen.
from puppet-nginx.
I have included a way to suppress logs in #888
We do have some use cases that require setting different roots per location, but agree that the default behavior could be improved.
I'm going to close this one, just because it hasn't had any activity in ages, but, as they say, pull requests (with tests) will be reviewed and gratefully accepted if this is still an issue.
from puppet-nginx.
Related Issues (20)
- documenting the email reverse proxy configuration
- Default package_ensure value is not compatible with current stdlib default for ensure_packages() HOT 3
- stream logging is broken by default HOT 2
- Unable to set valid Unix socket as upstream server
- REFERENCE's internal links are broken HOT 3
- access log inside rewrite_www_to_non_www and rewrite_non_www_to_www HOT 3
- custom stream_log not properly defined HOT 1
- Allow puppetlabs-concat 8 HOT 2
- Good SSL configuration by default HOT 3
- Allow multiple parameters for gzip_proxied
- limit_zone should take Array in addition to String and Undef HOT 1
- proxy_cache_path should allow different values for its settings when an hash is used.
- Documentation of "proxy_set_header Proxy" field
- Remove deprecated `ssl` directive HOT 5
- [DOC] add examples for `limit_conn` and `limit_req`
- Support ssl_reject_handshake and ssl_early_data
- FeatureRequest: AmazonLinux support
- [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in [from nginx 1.25.1 onwards] HOT 8
- add `host_core` fixture for acceptance tests
- `nginx::string_mappings` in last tag v6.0.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-nginx.