Attempt to redefine entity when using firewalld_port about puppet-firewalld HOT 6 CLOSED

@tallsam this is interesting - we weren't previously testing 4.7.0, I've added this to the test matrix and it passes the tests.

I did find this, claiming to be fixed in 4.6.1, https://tickets.puppetlabs.com/browse/PUP-6653

Have you used the 'puppet generate types' feature on your PE installation? - I'll continue to track this down but any more info that you have would be useful.

from puppet-firewalld.

@tallsam I was unable to reproduce this error on 4.7.0, with generated types, in multiple environments - can you give me a better idea of all the firewalld_* types you are invoking and from where? Either in the ticket or by email to [email protected] so I can investigate this further?

Also - you mention you are running different versions.... which ones?

from puppet-firewalld.

@crayfishx , sorry for taking a while to get back to this, and thanks for your work. We are on puppet 4.8 now.

I tried 3.1.7, 3.0.2, 2.2.0.

Pretty sure its something to do with the server configuration here, its running Oracle Linux 7, which is basically CentOS7. Since its an internal server i tried dropping everything from iptables but it didn't seem to help. edit I have it working on a virtual machine, but when I try run it on the server it fails.

Here are my invocations of firewalld:

[root@server r_server]# grep firewalld * -R -A 5
manifests/opencpu.pp:  firewalld_port { 'Port 80 for opencpu':
manifests/opencpu.pp-    ensure  => present,
manifests/opencpu.pp-    zone    => 'public',
manifests/opencpu.pp-    port   => 80,
manifests/opencpu.pp-    protocol   => 'tcp',
manifests/opencpu.pp-  }
[root@server r_server]# cd ../r_packages/
[root@server r_packages]# grep firewalld * -R -A 5
manifests/init.pp:    require firewalld
manifests/init.pp-
manifests/init.pp-    @package { 'libxml2-devel':
manifests/init.pp-        ensure => installed,
manifests/init.pp-    }
manifests/init.pp-
--
manifests/rserve.pp:  firewalld_port { 'Port 6311 for Rserve':
manifests/rserve.pp-    ensure  => present,
manifests/rserve.pp-    zone    => 'public',
manifests/rserve.pp-    port   => 6311,
manifests/rserve.pp-    protocol   => 'tcp',
manifests/rserve.pp-  }
--
manifests/rstudio.pp:  firewalld_port { 'Port 8787 for RStudio':
manifests/rstudio.pp-    ensure   => present,
manifests/rstudio.pp-    zone     => 'public',
manifests/rstudio.pp-    port     => 8787,
manifests/rstudio.pp-    protocol => 'tcp',
manifests/rstudio.pp-  }

from puppet-firewalld.

So I didn't require firewalld in the r_server package. Working fine now. The error threw me off though. Thanks for your time!

from puppet-firewalld.

@tallsam I think you may have fixed it by accident - there appears to be some odd behaviour depending on what order things are evaluated in the manifest, see https://tickets.puppetlabs.com/browse/PUP-6922

For now, I'm going to re-open this issue to keep it on the radar - I encountered a similar problem changing some of the dependencies around firewalld_direct_purge in the manifest.

from puppet-firewalld.

FYI @tallsam #103 will fix the errors you were seeing, it will get released in 3.1.8 shortly.... Your set up is working but only because of the ordering of type evaluation in your manifests, I would suggest upgrading to 3.1.8 anyway to ensure that the problem doesn't regress for you.

from puppet-firewalld.