Comments (10)
Interesting issue. can you give me an example value for the ES_JAVA_OPTS?
Will do some investigation on this and add testing.
from puppet-elasticsearch.
I found this discussion from a while back, but I think the solution is valid. http://www.redhat.com/archives/augeas-devel/2008-October/msg00023.html
In a quick test I put single quotes around the <%= value %> in defaults.erb so it looks like this:
<% @init_defaults.sort.map do |key, value| -%>
set <%= key %> '<%= value %>'
<% end -%>
Then, in my init_defaults hash I set
ES_JAVA_OPTS => '"-Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.port=9012 -Dcom.sun.management.jmxremote.ssl=false"'
as an example (that's double quotes wrapped in single quotes). The end result is that the set command looks like:
set ES_JAVA_OPTS '"-Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.port=9012 -Dcom.sun.management.jmxremote.ssl=false"'
The double quotes carry through and end up as the following line in /etc/sysconfig/elasticsearch - and works beautifully.
ES_JAVA_OPTS="-Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.port=9012 -Dcom.sun.management.jmxremote.ssl=false"
Would you be interested in a fix like this? It's completely backward compatible as far as I can tell.
from puppet-elasticsearch.
Ahh interesting. Totally didn't expect that.
Assuming it won't cause any issues with other values ( numbers, true/false ) im happy with the fix :-)
from puppet-elasticsearch.
Ok, I'll see if I can write some tests. Thanks for the feedback.
from puppet-elasticsearch.
I made the change. I don't think it will break current tests. I'm struggling to get the tests working on my box so I'm not sure if I'll be able to add new tests.
from puppet-elasticsearch.
What command is needed to execute the tests? Including ENV vars? I think that's my issue.
from puppet-elasticsearch.
Hi,
Commands are in .travis.yml file but might fail in certain scenario's because i messed something up.
bundle install
bundle exec rake spec SPEC_OPTS='--format documentation'
from puppet-elasticsearch.
\o/ Thank you!
from puppet-elasticsearch.
Updated PR #106 with tests to account for this change.
from puppet-elasticsearch.
I'm seeing this with the latest version of the module (from the forge - 0.15.0).
Since we cannot specify ES_HEAP_SIZE anymore with elasticsearch 5, I set ES_JAVA_OPTS but when I try with the space (ES_JAVA_OPTS="-Xms8g -Xmx8g"
) then augeasproviders_shellvar fails.
When I try with just ES_JAVA_OPTS="-Xmx8g"
it works fine.
Anyone aware of a workaround?
from puppet-elasticsearch.
Related Issues (20)
- typo in config.pp HOT 1
- Package not set to status hold on Debian
- Please publish tag 8.0.0 to forge HOT 1
- Release 8.0.0 not tagged HOT 3
- elasticsearch_keystore can't modify frozen String
- elasticsearch_keystore resource fails due to legacy instance code HOT 3
- Node facts not generated when Elasticsearch in cluster mode
- Could not evaluate: undefined method `join' for :name:Symbol HOT 2
- elasticsearch_plugin/ruby.rb wrong path to call plugin binary HOT 2
- ssl=true and version is not defined, gives an error HOT 1
- Setting an Elastic Version should be optional HOT 1
- New release, please HOT 1
- OpenSearch support ? HOT 1
- Elasticsearch API responded with: no handler found for uri [/_xpack/license?acknowledge=true] and method [PUT]
- File jvm.options in root is unmanaged/may be missing
- why was log4j2.properties.erb configuration commented ? HOT 1
- warnings when used with stlib 9. HOT 1
- fix lib directory permissions without changing the mode of files in the directory
- puppet-elastic_stack version HOT 1
- Use Elasticsearch 7+ as default for configuration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-elasticsearch.