Git Product home page Git Product logo

Comments (2)

logicminds avatar logicminds commented on June 21, 2024

I have this working on my own fork with the following:

class FILE
      def initialize(_url, _options)
      end

      def normalize_path(uri)
        # URI for windows does not work as expected and returns a path without the root drive
        # this attempts to fix that
        if /^file:\/{2}([a-z,A-Z]?)/.match(uri.to_s)   # file://c:/one/two/three.zip
          uri.to_s.gsub(/^file:\/{2}([a-z,A-Z])?/, "#{$1}:")
        else
          uri.path
        end
      end

      def download(uri, file_path)
        src_path = normalize_path(uri)
        FileUtils.copy(src_path, file_path)
      end
    end

If this is acceptable I can make a PR.

from puppet-archive.

nanliu avatar nanliu commented on June 21, 2024

file:///d:/OSS/one/two/three.zip is technically correct, because I think file://d:/OSS/one/two/three.zip, would be host = d:, path = OSS, and this patch is implementing the wrong behavior (puppet:/// and not puppet:// because puppet://{server}/). So maybe implementing #77 is the better approach, because this is not intuitive for Windows.

from puppet-archive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.