Git Product home page Git Product logo

Comments (5)

ekohl avatar ekohl commented on July 23, 2024

voxpupuli/puppet_metadata#35 is merged and released in puppet_metadata 3.3.0.

That leaves the question of how to specify it. I'm leaning to a way to specify it in puppet_metadata. Either on the command line or via some config file. The config file has the benefit that we don't need to do some funky stuff in GHA, where you would need to use JSON to pass data structures around. It has the downside of maintaining an additional file in the repository.

I haven't investigated if we can actually added data to metadata.json. My use cases are that puppet-pulpcore supports some versions of Pulpcore and the same for puppet-candlepin. Listing those supported versions in metadata.json feels correct, because we also list the Puppet version as well as supported OS versions.

from gha-puppet.

ekohl avatar ekohl commented on July 23, 2024

voxpupuli/puppet_metadata#35 is merged and released in puppet_metadata 3.3.0.

And #41 uses this functionality.

from gha-puppet.

ekohl avatar ekohl commented on July 23, 2024

And theforeman/forklift#1712 (comment) explains how puppet-pulpcore uses this today.

from gha-puppet.

evgeni avatar evgeni commented on July 23, 2024

https://www.puppet.com/docs/puppet/7/modules_metadata.html#modules_metadata-metadata-version-requirement says:

The requirements key specifies external requirements for the module, particularly the Puppet version required. Although you can express any requirement here, the Forge module pages and search function support only the "puppet" value, which specifies the Puppet version.

Which makes me think that specifying

  "requirements": [
    {
      "name": "puppet",
      "version_requirement": ">= 7.0.0 < 8.0.0"
    },
    {
      "name": "pulpcore",
      "version_requirement": "3.21 || 3.22 || 3.28"
    }
  ]

should totally work.

(the same wording is also used on the Puppet 6 and Puppet 8 pages)

from gha-puppet.

ekohl avatar ekohl commented on July 23, 2024

Not sure why it isn't closed, but #42 was merged.

from gha-puppet.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.