Git Product home page Git Product logo

Comments (7)

flibbertigibbet avatar flibbertigibbet commented on August 29, 2024

These addresses fail to geocode in the Google geocoder API, probably because they contain the ward number.

from android-white-label-app.

jen-tolentino avatar jen-tolentino commented on August 29, 2024

It works in the VIT, do you know why is it not geocoding in the app?

http://s3.amazonaws.com/vip-voter-information-tool/official.html

image

from android-white-label-app.

flibbertigibbet avatar flibbertigibbet commented on August 29, 2024

I'm not familiar with the web app; it may be using a different geocoding API for JavaScript, or it may be stripping the second line of the address. In any case, I don't think ward numbers should be in the address, as it is not a valid address component.

from android-white-label-app.

jen-tolentino avatar jen-tolentino commented on August 29, 2024

Can we modify how the app geocodes early vote sites to ensure they all displayed then? I can this is a very important fix.

Regarding the address validity, I'm not sure what you mean about the ward numbers.

from android-white-label-app.

flibbertigibbet avatar flibbertigibbet commented on August 29, 2024

The addresses that fail to geocode (in the screenshot above) all include the ward number as part of the address field; this information should not be in the address, as it is not a valid component to a street address. For example:

1480 Girard St NW Ward 1
Washington, DC

does not geocode, but

1480 Girard St NW
Washington, DC

would geocode properly, as it is the actual street address.

If possible in future, it would be both more efficient and less error prone if the geocoded co-ordinates for all locations were part of the API, rather than the addresses being repeatedly geocoded client-side.

from android-white-label-app.

jen-tolentino avatar jen-tolentino commented on August 29, 2024

I see what you're saying, thanks for explaining.

I'll see if we can strip "Ward" from the DC list, but can you also see if there's something we can do if we come across this issue in the future? I don't think this is change we can make quickly, and its definitely possible that it will appear other places.

I'm assuming the embeddable tool is able to handle the addresses because its built differently, but is there any way to modify the app, or is there too big of a difference between the two that what works in one, won't necessarily in the other?

from android-white-label-app.

flibbertigibbet avatar flibbertigibbet commented on August 29, 2024

#69 should address the issue. Second and third address lines will be ignored by the app.

from android-white-label-app.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.