Git Product home page Git Product logo

Comments (6)

vosmiic avatar vosmiic commented on July 17, 2024 1

I believe I have got it working, however it will not actually use the Anidb ID stored, as Jellyfin stores the first season's ID (as you have found out in your original post) only.
However, it will fallback to using the TVDB ID if available which handles seasons a bit better in our situation.
As you can see from my logs, it was able to successfully detect the shows correct season

[20:45:05] [INF] [54] jellyfin_ani_sync.UpdateProviderStatus: Anime already has AniDb ID; no need to look it up
[20:45:05] [WRN] [54] jellyfin_ani_sync.UpdateProviderStatus: Anime not found in anime list XML; relying on other metadata providers if available...
[20:45:05] [INF] [54] jellyfin_ani_sync.UpdateProviderStatus: Anime reference found in anime list XML
[20:45:05] [INF] [54] jellyfin_ani_sync.UpdateProviderStatus: Retrieving provider IDs from offline database...
[20:45:06] [INF] [59] jellyfin_ani_sync.UpdateProviderStatus: Retrieved provider IDs
[20:45:06] [INF] [59] jellyfin_ani_sync.UpdateProviderStatus: Using provider AniList...
[20:45:06] [INF] [59] jellyfin_ani_sync.UpdateProviderStatus: (AniList) Series ({{Season 2 of show}}) not found in plan to watch list, checking completed list..

Feel like I need to change the order of the provider compatibility wiki page after our recent findings.
The fix is out on master if you want to use the plugin with the fixes immediately, but it will be available in the next release if you have the plugin installed via the manifest.

If you are still having problems, feel free to open a new issue or re-open this one.

from jellyfin-ani-sync.

vosmiic avatar vosmiic commented on July 17, 2024

Hmm this was the main reason I released the hotfix, could you please confirm you have it installed?

episode.Season.IndexNumber.Value == 1 &&

This specific line should mean that other metadata providers are used if the season is not the first.

from jellyfin-ani-sync.

Pecomare avatar Pecomare commented on July 17, 2024

I just reinstalled 2.0.1.0 over my workaround (commenting out the continues in the switch) and the problem still occurs.

[2022-06-14 18:26:05.108 +00:00] [INF] [15] jellyfin_ani_sync.ServerEntry: (AniList) Series (Love Live! Nijigasaki High School Idol Club) found on completed list, setting as re-watching
[2022-06-14 18:26:05.115 +00:00] [INF] [15] jellyfin_ani_sync.ServerEntry: (AniList) Series (Love Live! Nijigasaki High School Idol Club) has already been watched, marking anime as re-watching; progress of 11

I don't go into that block of code, though, as that line 87 shows, but I go in the else if as episode.Series.ProviderIds.ContainsKey("Anidb") evaluates to true, so providerIds is set, thus providerIds.Anilist != 0 will evaluate to true while not being the right ID.

from jellyfin-ani-sync.

vosmiic avatar vosmiic commented on July 17, 2024

I am testing this and it seems to work for me, and I have the same provider IDs as you. Got to work out what is different in your situation.
I presume you are debugging since you are following the execution path, are you able to see what the values are at this location

var foundAnime = animeListXml.Anime.Where(anime => int.TryParse(anime.Tvdbid, out int xmlTvDbId) && xmlTvDbId == tvDbId &&
int.TryParse(anime.Defaulttvdbseason, out int xmlSeason) && xmlSeason == seasonNumber).ToList();

as for me that contains a single value in the list, which is the 2nd season.

from jellyfin-ani-sync.

Pecomare avatar Pecomare commented on July 17, 2024

I don't even go into that path either, since I have an AniDB ID

[2022-06-14 21:20:02.860 +00:00] [INF] [13] jellyfin_ani_sync.UpdateProviderStatus: season: 2, episode: 11, providers: 'Tvdb': '388317', 'AniList': '113970', 'AniDB': '15313', 'Tmdb': '103511', 'Imdb': 'tt12792684'
[2022-06-14 21:20:02.860 +00:00] [INF] [13] jellyfin_ani_sync.UpdateProviderStatus: Anime already has AniDb ID; no need to look it up
[2022-06-14 21:20:02.860 +00:00] [INF] [13] jellyfin_ani_sync.UpdateProviderStatus: 15313

I added the third log line just to be sure of the execution path and that if is executed.

if (providers.ContainsKey("Anidb")) {
logger.LogInformation($"Anime already has AniDb ID; no need to look it up");
if (int.TryParse(providers["Anidb"], out aniDbId)) return (aniDbId, null);
} else if (providers.ContainsKey("Tvdb")) {

from jellyfin-ani-sync.

vosmiic avatar vosmiic commented on July 17, 2024

Ah I see what needs to be changed, we need to apply the season handling to the Anidb if statement.
Thanks for pointing it out and I'll keep you updated on the progress.

from jellyfin-ani-sync.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.