What is this bug about (expected vs actual behaviour)? expected:<b

<p> paragraphs break when compressing, closing tag missing about htmlmin HOT 7 CLOSED

voku commented on July 30, 2024

paragraphs break when compressing, closing tag missing

from htmlmin.

Comments (7)

posido commented on July 30, 2024 1

You may close this issue. Found a solution.

from htmlmin.

voku commented on July 30, 2024

https://google.github.io/styleguide/htmlcssguide.html#Optional_Tags

It's optional in HTML5. Do you see any problems in the browser?

from htmlmin.

posido commented on July 30, 2024

Unfortunately, yes. With compression and removed

my image gallery JavaScript layout switch works but shows the images completely strange. With a closing

it is as expected.

from htmlmin.

voku commented on July 30, 2024

Do you have an example (html code or a link) for me, maybe we can spot the error.

from htmlmin.

posido commented on July 30, 2024

Actually, not so easy. I use several NPM JS components relevant for switching the view mode of the gallery. The responsible JS code looks good:

    jQuery(".grid-system > a").on("click", function(event){
        event.preventDefault();
        var selector = jQuery(this).parent().parent().next().find('div.item');
        var classStr = jQuery(selector).attr('class'),
            lastClass = classStr.substr( classStr.lastIndexOf(' ') + 1);
        jQuery(selector)
            // Remove last class
            .removeClass(lastClass)
            // Put back .item class + the clicked elements class with the added prefix "group-item-".
            .addClass('item group-item-' + jQuery(this).attr('class') );
        if(jQuery(this).hasClass("current")!== true)
        {
            jQuery('.grid-system > a').removeClass("current");
            jQuery(this).addClass("current");
        }
    });

That's the whole JS code which switches the styles on click.

from htmlmin.

voku commented on July 30, 2024

Ok, I can't see anything with this code, but you can disable the feature via:

$htmlMin->doRemoveOmittedHtmlTags(false); // remove ommitted html tags e.g. <p>lall</p> => <p>lall

Does this workaround help you, should I close the issue?

from htmlmin.

posido commented on July 30, 2024

Hi, Yes that should help. Thanks. Just need to find out how to provide that option to voku/html-compress-twig within services.yaml (Symfony):

voku\helper\HtmlMin:
    tags:
        - { name: HtmlMin }

voku\twig\MinifyHtmlExtension:
    arguments:
        $forceCompression: false
    tags:
        - { name: twig.extension }

from htmlmin.

Recommend Projects