Multi language trasnlation not work about oc-twigextensions-plugin HOT 35 CLOSED

Reported it here.

from oc-twigextensions-plugin.

Thanks!

from oc-twigextensions-plugin.

But last time (#8) you fixed it, don't you?

from oc-twigextensions-plugin.

If I may interrupt - there is something wrong in the pt-br language files. I made the same mistake in the German ones. Only the plural versions have had a placeholder.
I just created a pull request to fix that.

from oc-twigextensions-plugin.

Thanks @manogi it may be solution. @ribsousa can you please test it on your website?

But it's weird, first section should be for singular version.

from oc-twigextensions-plugin.

You are right, when I think about it - it should actually just take the plural version.

from oc-twigextensions-plugin.

I'm sorry, my comment was wrong - the English files also just have the "1" and no placeholder, and that is perfectly fine like that. So the issue must lie somewhere else.

from oc-twigextensions-plugin.

And when you have sites in en and de locale, do they have same results? For example when you can see in English "1 hour ago", do you see same in German one?

from oc-twigextensions-plugin.

I have not tested yet if the problem only occurs with pt-br, I will enable German to verify this

from oc-twigextensions-plugin.

'timezone' => 'UTC',
In German returned the same result as English

The problem then is in pt-br?

from oc-twigextensions-plugin.

See! site change language

from oc-twigextensions-plugin.

Which is the official timezone for PT-BR? Is it same like English and German?

from oc-twigextensions-plugin.

No, Time Zone Brazil

from oc-twigextensions-plugin.

And when you set CMS timezone to Brazil, it prints correct translation?

from oc-twigextensions-plugin.

set 'timezone' => 'Brazil/East',
en/de print ok! 22 hours ago
pt-br print 1 hour ago

from oc-twigextensions-plugin.

Maybe we should have a look at the actual lang/pt-br/lang.php file in use here...

from oc-twigextensions-plugin.

You can check the result here

from oc-twigextensions-plugin.

I don't really know. The translations are taken from https://github.com/KnpLabs/KnpTimeBundle/tree/master/Resources/translations so they should be fine.

This plugin only connect October Translator with Twig Extensions plugin. It doesn't modify the data in any way, so I'm not sure. Maybe the problem is in Twig Extensions.

from oc-twigextensions-plugin.

It seems it always takes the singular version instead of the plural version.

The lang file in your repository looks fine. But maybe @ribsousa isn't really using that version? Is that an OctoberCMS installation or something else?

from oc-twigextensions-plugin.

October clean install!

from oc-twigextensions-plugin.

Which build? Try to enable edgeUpdates at config.

from oc-twigextensions-plugin.

I just tested this in one of my websites - I have the same problems with pt-br. But now can tweak the files and test better...

from oc-twigextensions-plugin.

If I replace the complete content of pt-br with the en lang file, I still get the same wrong results

from oc-twigextensions-plugin.

We are getting closer: if I rename "pt-br" to "pt" and use that, it works correctly.

from oc-twigextensions-plugin.

pt is Portuguese from Portugal

from oc-twigextensions-plugin.

I know - this is not about that, but about the fact that probably the "-" in the folder name is a problem. I could also have renamed it to "xy".

from oc-twigextensions-plugin.

ok!

from oc-twigextensions-plugin.

An underscore also works: renaming the folder to "pt_br" also had good results.
I will prepare a pull request. I guess @vojtasvoboda will merge it and put it on the market place.

Just make sure that after updating the twig extensions plugin you go directly to your language settings in octoberCMS and replace "pt-br" with "pt_br". And the css class of your flag to "flag-icon-pt_br" ;-)

from oc-twigextensions-plugin.

This is weird, OctoberCMS uses also pt-br:

• https://github.com/octobercms/october/tree/master/modules/backend/lang
• https://github.com/octobercms/october/tree/master/modules/cms/lang
• https://github.com/octobercms/october/tree/master/modules/system/lang

With pt_br it will not be compatible with OctoberCMS locale settings.

from oc-twigextensions-plugin.

Ah ok - closed my pull request. But then I'm out of my depth here and you need to take over ;-)

Maybe the knowledge that it works without the dash in the folder name helps a little.

from oc-twigextensions-plugin.

OK found it - but it is unfortunately a problem with OctoberCMS. It makes use of this class
But have a look at line 38: it checks if the locale name is longer than 3 characters and then tries to split it at the "_" sign. After that, the locale is basically empty, and the translation falls back to taking the first part of the string in your translation file. So OctoberCMS also should not be using "pt-br" and so on. But it probably never caused problems, because none of these files seem to use the singular/plural version of translation files...

from oc-twigextensions-plugin.

And can you report this behaviour directly to the October repository and mention this thread? I'm curious about solution :-)

from oc-twigextensions-plugin.

+1

from oc-twigextensions-plugin.

Actually renaming the folder to pt_br and changing the language setting to pt_br, it works. However octobercms uses pt-br; the problem seems to be even the "-" as reported by manogi.

from oc-twigextensions-plugin.

I'll wait for @manogi and his Issue to the OctoberCMS repo and we'll see where is the problem.

from oc-twigextensions-plugin.